[BPF] make conntrack timeouts configurable #9607
Merged
+1,171
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
tomastigera
added
docs-not-required
fasaxc
reviewed
Dec 18, 2024
tomastigera
force-pushed
the
tomas-bpf-ct-timeouts
branch
from
93d4e03 to
49ac572
Compare
tomastigera
force-pushed
the
tomas-bpf-ct-timeouts
branch
3 times, most recently
from
dd2d130 to
2413c56
Compare
tomastigera
force-pushed
the
tomas-bpf-ct-timeouts
branch
2 times, most recently
from
badbf68 to
762b351
Compare
There was a problem hiding this comment.
@tomastigera I'm just reviewing the API bits (others have reviewed the implementation IIUC).
Looking pretty good, but had a few questions / suggestions.
| // GenericIPLastSeen: nf_conntrack_generic_timeout | ||
| // ICMPLastSeen: nf_conntrack_icmp_timeout | ||
| // | ||
| // If there is no mapping, 'auto' is replaced by the default value. |
There was a problem hiding this comment.
Now that we have defined these as pointers I don't think we need a special "auto" field - nil means "use the default value", right? Or am I misunderstanding the semantics of "auto"?
There was a problem hiding this comment.
Yes we need auto to distinguish between "use the default" aka nil/unset and use the value from linux if available aka auto
There was a problem hiding this comment.
Got it - in that case, I think the description here isn't clear enough. That behavior wasn't obvious to me. I'll add a suggested edit.
BPFConntrackTimers overides the default values for the specified conntrack timer if
set. It is a struct of values, where each value can be either a duration or `auto` to
pick the value from a Linux conntrack timeout.
Possible values for the keys are: CreationGracePeriod, TCPPreEstablished,
TCPEstablished, TCPFinsSeen, TCPResetSeen, UDPLastSeen, GenericIPLastSeen,
ICMPLastSeen.
Unset or incorrect values are replaced by the default values with a warning log for
incorrect values.
Current auto mappings:
TCPPreEstablished: nf_conntrack_tcp_timeout_syn_sent
TCPEstablished: nf_conntrack_tcp_timeout_established
TCPFinsSeen: nf_conntrack_tcp_timeout_time_wait
GenericIPLastSeen: nf_conntrack_generic_timeout
ICMPLastSeen: nf_conntrack_icmp_timeout
If there is no mapping, 'auto' is replaced by the default value.
[Default:
CreationGracePeriod: 10s
TCPPreEstablished: 20s
TCPEstablished: 1h
TCPFinsSeen: auto (30s is default)
TCPResetSeen: 40s
UDPLastSeen: 60s
GenericIPLastSeen: 10m
ICMPLastSeen: 5s
]
tomastigera
force-pushed
the
tomas-bpf-ct-timeouts
branch
from
762b351 to
6b485e1
Compare
tomastigera
force-pushed
the
tomas-bpf-ct-timeouts
branch
from
137dcd5 to
52e8c8a
Compare
caseydavenport
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #9372
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.