Skip to content

Conversation

@sjproctor
Copy link

This commit fixes the malformed format string - %= error that occurs when ERB syntax is used in the downloads.yml file.

Screenshot 2024-11-07 at 4 40 09 PM

This commit fixes the `malformed format string - %=` error that occurs
when ERB syntax is used in the `downloads.yml` file.
@corylown
Copy link
Contributor

corylown commented Nov 8, 2024

Hi @sjproctor -- can you say a bit more about why this change is needed? The current downloads.yml pattern is to use %{} syntax that will evaluate accessor methods set on SolrDocument. What's the use case that this pattern doesn't cover?

@sjproctor
Copy link
Author

Hi @sjproctor -- can you say a bit more about why this change is needed? The current downloads.yml pattern is to use %{} syntax that will evaluate accessor methods set on SolrDocument. What's the use case that this pattern doesn't cover?

Hi there. I am looking to use an environment variable in the yml file. The ERB tags are causing an error.

@corylown
Copy link
Contributor

corylown commented Dec 5, 2024

@sjproctor I think CI was not working when you made this pull request. Can you rebase from the latest main? and if the tests pass this looks okay to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants