Skip to content

Easier override for Arclight::BookmarkComponent #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kirkkwang wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Easier override for Arclight::BookmarkComponent #1560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/arclight/document_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<%= document.normalized_title %>
<% end %>
<%= render 'arclight/requests', document: document %>
<%= render Arclight::BookmarkComponent.new document: document, action: bookmark_config %>
<%= render (blacklight_config.index.document_actions.arclight_bookmark_control.component || Arclight::BookmarkComponent).new document: document, action: bookmark_config %>
Copy link
Member

@cbeer cbeer Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<%= render (blacklight_config.index.document_actions.arclight_bookmark_control.component || Arclight::BookmarkComponent).new document: document, action: bookmark_config %>
<%= render (presenter&.view_config&.document_actions&.arclight_bookmark_control.component || Arclight::BookmarkComponent).new document: document, action: bookmark_config %>

I think the presenter should have the appropriate configuration context, maybe?

Copy link
Author

@kirkkwang kirkkwang Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cbeer, I don't seem to be finding what I'm looking for using the presenter view_config

image

<%= toggle_sidebar %>
<%= online_filter %>
</div>
Expand Down