Skip to content

get codeflare-operator from mcadv1b2 branch #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

dgrove-oss
Copy link
Collaborator

Attempt at minimal changes to enable merging of mcadv1b2 branch of codeflare operator.

Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maxusmusti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgrove-oss dgrove-oss added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2024
@dgrove-oss dgrove-oss force-pushed the minimal-appwrapper branch from 593c87e to 5017f83 Compare April 4, 2024 18:27
@dgrove-oss dgrove-oss force-pushed the minimal-appwrapper branch from 5017f83 to dcd6685 Compare April 4, 2024 18:51
The CodeFlare operator checks for the presence of Ray CRDs to decide
whether or not to run the RayCluster ingress controller. Therefore
we need to deploy KubeRay before deploying the CodeFlare operator.
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2024
@dgrove-oss
Copy link
Collaborator Author

Closing as outdated.

@dgrove-oss dgrove-oss closed this Apr 16, 2024
@dgrove-oss dgrove-oss deleted the minimal-appwrapper branch April 16, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants