Skip to content

Upgrade from AppWrapper v1beta1 to v1beta2 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dgrove-oss
Copy link
Collaborator

Issue link

What changes have been made

Context: This PR supports the migration of the codeflare operator from MCADv1 to Kueue+AppWrapper. We should probably wait on merging this PR until the corresponding PRs on the consuming codeflare repos are ready, as the removal of MCADv1 CRDs is a breaking change.

Change summary

  1. Replace MCAD dependency with AppWrapper
  2. Upgrade AppWrapper from v1beta1 to v1beta2
  3. Upgrade to go 1.21
  4. Upgrade go dependencies to match Kueue/AppWrapper requirements
  5. Fix bug in fakeclient initialization (dynamic interface not initialized)

Verification steps

I manually ran go test ./support/. -v

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • [ x ] Unit tests
    • Manual tests
    • Testing is not required for this change

1. Replace MCAD dependency with AppWrapper
2. Upgrade AppWrapper from v1beta1 to v1beta2
3. Upgrade to go 1.21
4. Upgrade go dependencies to match Kueue/AppWrapper requirements
5. Fix bug in fakeclient initialization (dynamic interface not initialized)
@openshift-ci openshift-ci bot requested review from astefanutti and sutaakar March 15, 2024 19:03
Copy link

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgrove-oss
Once this PR has been reviewed and has the lgtm label, please assign astefanutti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgrove-oss
Copy link
Collaborator Author

Meant to use the branch in the codeflare repo; not my fork. Closing and will recreate a new one.

@dgrove-oss dgrove-oss closed this Mar 15, 2024
@dgrove-oss dgrove-oss deleted the mcadv1b2 branch March 15, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant