Skip to content

Support package refactor#1

Merged
Fiona-Waters merged 7 commits intoproject-codeflare:mainfrom
Fiona-Waters:support-package-refactor
Oct 18, 2023
Merged

Support package refactor#1
Fiona-Waters merged 7 commits intoproject-codeflare:mainfrom
Fiona-Waters:support-package-refactor

Conversation

@Fiona-Waters
Copy link
Copy Markdown
Contributor

@Fiona-Waters Fiona-Waters commented Oct 13, 2023

Issue link

project-codeflare/codeflare-operator#237

What changes have been made

  • Moved the support files from the Codeflare Operator Repo to this new separate repo for common functions.
  • Added Makefile and moved verify-imports.sh in order to be able to verify imports are correct.

Questions:

  • Do we want to group the files further within the support directory?
  • We should have an OWNERS file - Who should be added as approvers and reviewers?
  • Do we want to add PR checks for this repo now?

Verification Steps

  • Once the Codeflare Operator repo is updated to reflect these changes we can verify that everything works as expected.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@ChristianZaccaria
Copy link
Copy Markdown
Contributor

ChristianZaccaria commented Oct 13, 2023

/lgtm /approve

Comment thread Makefile
Comment thread Makefile
OPENSHIFT-GOIMPORTS ?= $(LOCALBIN)/openshift-goimports

.PHONY: openshift-goimports
openshift-goimports: $(OPENSHIFT-GOIMPORTS) ## Download openshift-goimports locally if necessary.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bring the corresponding GH actions workflows there too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify_generated_files workflow added.

@Fiona-Waters Fiona-Waters merged commit 4c8cdf6 into project-codeflare:main Oct 18, 2023
@Fiona-Waters Fiona-Waters mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants