Repository navigation
test(preset): solve the generated CSS with @csstools/css-calc - #10
Merged
Merged
Conversation
The v2 test evaluated the preflight by translating CSS into JavaScript and running it through `new Function`. It now substitutes `var()` and lets @csstools/css-calc (the CSS math engine of postcss-preset-env) solve `calc()`, `cos()`, `sin()` and `max()`, so the comparison with `fittedOklch` checks CSS semantics rather than our own translation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nekomeowww
force-pushed
the
test/preset-css-calc
branch
from
October 27, 2026 21:40
1d4421b to
a35a77e
Compare
✅ Deploy Preview for proj-airi-chromatic ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v2 test in
shared.fitted.test.tschecks that the CSS emitted by the preset computes the same lightness, chroma and hue drift asfittedOklch. Its evaluator used to translate CSS into JavaScript (calc(→(,cos(→Math.cos(, …) and run it throughnew Function. That checked our own translation more than CSS.It now substitutes
var()references, then solves the math functions with@csstools/css-calc, the CSS math engine behind postcss-preset-env. It coverscalc(),cos(),sin(),max()and friends with CSS semantics.@csstools/*packages are added. pnpm also wanted to dedupe unrelated packages; that was left out.Test plan
pnpm install --frozen-lockfile,pnpm lint,pnpm typecheck,pnpm build,pnpm test:run(26 tests).cos/sinin the preset's CSS generator makes the comparison test fail. Restored afterwards.🤖 Generated with Claude Code