Add JSON-LD Support #20
Merged
+152
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I have fixed the type issues for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #19
This PR adds JSON-LD support (conforming to schema.org) for the following pages:
/now includes JSON-LD markup for the general podcast series (according to https://schema.org/CreativeWorkSeries)/podcast/*now includes JSON-LD markup for the specific podcast episode (according to https://schema.org/PodcastEpisode)/hall-of-fame/*now includes JSON-LD markup for the specific person (according to https://schema.org/Person)Given that each of these schemas is rather complex, there certainly are possibilities to include even more detailed information. But this seems like a solid first take.
All pages have been verified via schema.org (see attached screenshots)
PS: While the code is functional, some TypeScript warnings have been thrown that I was not able to resolve. Hints are welcome, especially for this file
nuxt-app/helpers/jsonLdGenerator.ts