Skip to content

Fix referral quota for existing recipients #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 2 commits into from
Jun 14, 2026
Merged

Fix referral quota for existing recipients #442

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a1887d
Fix referral quota duplicate recipients
Jun 13, 2026
633c986
Handle referral duplicate lookup errors
Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 22 additions & 23 deletions src/app/api/referrals/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,27 @@ export async function POST(request: NextRequest) {
);
}

// Spam throttling: max 50 invites per day, max 10 per hour
// Only count valid emails toward rate limits (#143)
const svc = createServiceClient();

// Prevent duplicate invites to same email before quota math.
const { data: existingInvites } = await (svc as AnySupabase)
.from("referrals")
.select("referred_email")
.eq("referrer_id", user.id)
.in("referred_email", validEmails);

const alreadyInvited = new Set((existingInvites || []).map((r: any) => r.referred_email));
const newValidEmails = validEmails.filter((e: string) => !alreadyInvited.has(e));
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated

if (newValidEmails.length === 0) {
return NextResponse.json(
{ error: "All these emails have already been invited" },
{ status: 400 }
);
}

// Spam throttling: max 50 invites per day, max 10 per hour.
// Only new valid emails should count toward rate limits.
const oneHourAgo = new Date(Date.now() - 60 * 60 * 1000).toISOString();
const oneDayAgo = new Date(Date.now() - 24 * 60 * 60 * 1000).toISOString();

Expand All @@ -112,7 +130,7 @@ export async function POST(request: NextRequest) {
.eq("referrer_id", user.id)
.gte("created_at", oneHourAgo);

if ((hourlyCount ?? 0) + validEmails.length > 10) {
if ((hourlyCount ?? 0) + newValidEmails.length > 10) {
return NextResponse.json(
{ error: "Too many invites. Max 10 per hour." },
{ status: 429 }
Expand All @@ -125,22 +143,13 @@ export async function POST(request: NextRequest) {
.eq("referrer_id", user.id)
.gte("created_at", oneDayAgo);

if ((dailyCount ?? 0) + validEmails.length > 50) {
if ((dailyCount ?? 0) + newValidEmails.length > 50) {
return NextResponse.json(
{ error: "Daily invite limit reached. Max 50 per day." },
{ status: 429 }
);
}

// Prevent duplicate invites to same email
const { data: existingInvites } = await (svc as AnySupabase)
.from("referrals")
.select("referred_email")
.eq("referrer_id", user.id)
.in("referred_email", validEmails);

const alreadyInvited = new Set((existingInvites || []).map((r: any) => r.referred_email));

// Get user's referral code
const { data: profile } = await (supabase as any)
.from("profiles")
Expand All @@ -155,16 +164,6 @@ export async function POST(request: NextRequest) {
const referralCode = profile.referral_code || profile.username;
const inviterName = profile.full_name || profile.username || "Someone";

// Filter valid emails that aren't already invited (#143)
const newValidEmails = validEmails.filter((e: string) => !alreadyInvited.has(e));

if (newValidEmails.length === 0) {
return NextResponse.json(
{ error: "All these emails have already been invited" },
{ status: 400 }
);
}

// Send emails BEFORE inserting into DB to avoid partial-state issues
const emailContent = referralInviteEmail({ inviterName, referralCode });
const emailResults = await Promise.all(
Expand Down