Normalize gig pagination params

[rissrice2105-agent]

Normalizes /api/gigs pagination params before validation and querying. Fractional page/limit values are now truncated to integers, invalid values default safely, and the Supabase range plus pagination metadata stay integer and bounded.

Validation:

• vitest run src/app/api/gigs/route.test.ts
• tsc --noEmit

[greptile-apps]

Greptile Summary

This PR replaces the inline Math.min(Number(param) || default, max) expressions for page and limit with a dedicated parsePositiveIntegerParam helper that correctly handles fractional inputs (via Math.trunc), non-numeric strings, Infinity, and negative values before the filters reach schema validation or Supabase.

• parsePositiveIntegerParam normalizes any string/null to a positive integer in [1, max], covering null/empty → default, NaN/Infinity → default, fractions → truncated, and negatives/zero → clamped to 1.
• Two new tests verify the fractional-truncation path (\"2.9\" → 2, \"5.9\" → 5, range(5,9)) and the invalid/non-positive-defaulting path (\"-10\" → 1, \"abc\" → 20, range(0,19)).

Confidence Score: 4/5

Safe to merge; the normalization logic is correct for all tested and traced edge cases, and the Supabase range arguments remain bounded integers.

The implementation correctly handles every meaningful edge case — null, whitespace, NaN, Infinity, fractions, negatives, zero, and oversized values — and the two new tests confirm the key paths. The only gap is that explicit page=0 / limit=0 input (a finite, non-NaN value that still gets clamped to 1 via Math.max) has no dedicated test, leaving that specific clamping path unverified.

Both changed files are low risk; route.test.ts would benefit from adding a page=0 / limit=0 test case.

Important Files Changed

Filename	Overview
src/app/api/gigs/route.ts	Adds parsePositiveIntegerParam helper to replace inline Number(...)
src/app/api/gigs/route.test.ts	Adds two new test cases covering fractional truncation and invalid/non-positive defaulting; good range and pagination assertions but misses explicit coverage for page=0 / limit=0 inputs being clamped to 1.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["searchParams.get('page' or 'limit')"] --> B{value null or whitespace?}
    B -- "yes" --> C["use defaultValue (1 or 20)"]
    B -- "no" --> D["Number(value)"]
    D --> E{isFinite?}
    E -- "no (NaN, Infinity)" --> C
    E -- "yes" --> F["Math.trunc(parsed)"]
    C --> F
    F --> G["Math.max(1, truncated)"]
    G --> H["Math.min(result, MAX_GIG_PAGE or MAX_GIG_LIMIT)"]
    H --> I["integer in [1, max]"]
    I --> J["offset = (page-1) * limit"]
    J --> K["supabase.range(offset, offset + limit - 1)"]

Loading

_{Reviews (1): Last reviewed commit: "Normalize gig pagination params" | Re-trigger Greptile}

[greptile-apps]

Missing test for explicit zero input clamping

The two new tests cover fractions and non-positive strings, but neither passes page=0 or limit=0 explicitly. Number("0") = 0 is finite and non-NaN, so the fallback to defaultValue is skipped — the value travels all the way to Math.max(1, Math.trunc(0)), which correctly returns 1. That path isn't exercised by any existing test, leaving a gap in the zero-input contract. A test asserting range(0, 19) when page="0" (and default limit=20) would close it.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[ralyodio]

Closing in favor of a new PR that includes the bounties test fix from master. The gig pagination changes are correct and will be re-submitted.