Skip to content

sh1pt: install Node pnpm CI (node-pnpm-ci@1.0.0)#396

Merged
ralyodio merged 2 commits into
masterfrom
sh1pt/actions/node-pnpm-ci/20260604-212018
Jun 4, 2026
Merged

sh1pt: install Node pnpm CI (node-pnpm-ci@1.0.0)#396
ralyodio merged 2 commits into
masterfrom
sh1pt/actions/node-pnpm-ci/20260604-212018

Conversation

@sh1pt-actions-fleet

Copy link
Copy Markdown
Contributor

sh1pt Actions Fleet: install Node pnpm CI

Installs Node pnpm CI (node-pnpm-ci@1.0.0) from the sh1pt Actions Store.

Files

  • .github/workflows/ci.yml — create

Required secrets

No new secrets required.

Notes

  • Generated workflow files include a managed comment with a sha256 of the rendered body, so future updates can be detected without overwriting hand-edits.
  • Install mode: pull request (no direct commits).
  • Rollback: close this PR or revert the merge commit.

Generated by sh1pt Actions Fleet.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

vu1nz Security Review

0 finding(s) in PR #?

No security issues found.

@greptile-apps

greptile-apps Bot commented Jun 4, 2026

Copy link
Copy Markdown

Greptile Summary

This PR introduces a new GitHub Actions CI workflow generated by the sh1pt Actions Fleet, running type-check and tests on every push to main/master and on pull requests using Node 22 and pnpm 9.

  • The workflow correctly uses pnpm type-check (matching the package.json script name) and sets a reasonable 15-minute timeout with concurrency cancellation.
  • pnpm lint is not included, so ESLint violations that don't cause TypeScript errors will pass CI silently — the project's own precommit script runs lint as its first step.
  • pnpm build is also absent, meaning a broken Next.js production build (edge-runtime restrictions, build-time env issues, etc.) would not be caught by this workflow.

Confidence Score: 5/5

Safe to merge — the workflow adds useful CI coverage without touching any application code.

Only a single YAML file is added. It uses pinned, well-known actions, applies least-privilege permissions, and correctly references existing package.json scripts. The omitted lint and build steps are gaps in coverage rather than anything that would break the repository.

No files require special attention beyond the suggestions on .github/workflows/ci.yml.

Important Files Changed

Filename Overview
.github/workflows/ci.yml New CI workflow installing Node 22, pnpm 9, running type-check and tests; correctly names the type-check script, but omits a build verification step and lint step that are both part of the project's precommit script.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Push or PR event] --> B[checkout v4]
    B --> C[pnpm setup v4 pnpm-9]
    C --> D[setup-node v4 Node-22]
    D --> E[pnpm install frozen-lockfile]
    E --> F[pnpm type-check]
    F --> G[pnpm test]
    G --> H[Job passes]
Loading

Reviews (2): Last reviewed commit: "fix(ci): use correct script name pnpm ty..." | Re-trigger Greptile

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml

- run: pnpm typecheck

- run: pnpm test

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The test script is defined as vitest (watch mode). While GitHub Actions sets CI=true and vitest will honour that by running once, the explicit test:run script (vitest run) is more reliable and removes any ambiguity about whether the suite hangs waiting for input.

Suggested change
- run: pnpm test
- run: pnpm test:run

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@ralyodio ralyodio merged commit 1146cb6 into master Jun 4, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant