✨ preserve user history with soft deletion#1987
Open
BenoitSerrano wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
🚥 e2e
🧪 unit test
scope: identite
🗄️ migrations
scope: database
labels
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
**Problem** Deleting a user permanently removes all associated history and records. **Proposal** Perform a soft delete when removing a user so that historical data is preserved.
BenoitSerrano
force-pushed
the
add-soft-delete
branch
from
fe35678 to
3f5c69d
Compare
douglasduteil
approved these changes
Jun 9, 2026
douglasduteil
left a comment
douglasduteil
left a comment
Contributor
There was a problem hiding this comment.
Very cool !
Should we close #1415 then ?
| }); | ||
| }); | ||
|
|
||
| test("❎ fail to find the God-Emperor of Mankind if not active", async () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| test("❎ fail to find the God-Emperor of Mankind if not active", async () => { | |
| test("❎ fail to find the Lion El'Jonson if deleted", async () => { |
| }); | ||
| }); | ||
|
|
||
| test("❎ fail to find the God-Emperor of Mankind if not active", async () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| test("❎ fail to find the God-Emperor of Mankind if not active", async () => { | |
| test("❎ fail to find Lion El'Jonson if deleted", async () => { |
| }); | ||
| }); | ||
|
|
||
| test("❎ fail to find the God-Emperor of Mankind", async () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| test("❎ fail to find the God-Emperor of Mankind", async () => { | |
| test("❎ fail to find Lion El'Jonson if deleted", async () => { |
Contributor
Author
rdubigny
reviewed
Jun 11, 2026
rdubigny
left a comment
rdubigny
left a comment
Contributor
There was a problem hiding this comment.
Thought: I find this proposal well executed but intrusive: the notion of “active” is spread widely across the code, in places where we do not want to deal with this notion. I also find this error-prone, as the odds are high that the next time we want to list users, we forget to filter against the deleted_at field.
Also, the problem you are trying to solve is unclear to me.
I am not confident merging this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deleting a user permanently removes all associated history and records.
Proposal
Perform a soft delete when removing a user so that historical data is preserved.