Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions src/webgl/p5.RendererGL.Immediate.js
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,37 @@ p5.RendererGL.prototype._tesselateShape = function() {
this.immediateMode.geometry.vertexNormals[i].z
);
}

// Normalize nearly identical consecutive vertices to avoid numerical issues in libtess.
// This workaround addresses tessellation artifacts when consecutive vertices have
// coordinates that are almost (but not exactly) equal, which can occur when drawing
// contours automatically sampled from fonts with font.textToContours().
const epsilon = 1e-6;
for (const contour of contours) {
for (
let i = p5.RendererGL.prototype.tessyVertexSize;
i < contour.length;
i += p5.RendererGL.prototype.tessyVertexSize
) {
const prevX = contour[i - p5.RendererGL.prototype.tessyVertexSize];
const prevY = contour[i - p5.RendererGL.prototype.tessyVertexSize + 1];
const prevZ = contour[i - p5.RendererGL.prototype.tessyVertexSize + 2];
const currX = contour[i];
const currY = contour[i + 1];
const currZ = contour[i + 2];

if (Math.abs(prevX - currX) < epsilon) {
contour[i] = prevX;
}
if (Math.abs(prevY - currY) < epsilon) {
contour[i + 1] = prevY;
}
if (Math.abs(prevZ - currZ) < epsilon) {
contour[i + 2] = prevZ;
}
Comment on lines +464 to +466
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason for snapping the z coordinates as well? I don't think we need to do that for z?

}
}

const polyTriangles = this._triangulate(contours);
const originalVertices = this.immediateMode.geometry.vertices;
this.immediateMode.geometry.vertices = [];
Expand Down
31 changes: 31 additions & 0 deletions test/unit/visual/cases/webgl.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,4 +141,35 @@ visualSuite('WebGL', function() {
screenshot();
});
});

visualSuite('Tessellation', function() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new visual test doesn’t actually cover this change. I see the same output before and after the patch. Please update the sketch to reproduce the bug which is fixed at your PR.

visualTest('Handles nearly identical consecutive vertices', function(p5, screenshot) {
p5.createCanvas(100, 100, p5.WEBGL);
p5.pixelDensity(1);
p5.background(255);
p5.fill(0);
p5.noStroke();

// Contours with nearly identical consecutive vertices (as can occur with textToContours)
// Outer contour
p5.beginShape();
p5.vertex(-30, -30, 0);
p5.vertex(30, -30, 0);
p5.vertex(30, 30, 0);
p5.vertex(-30, 30, 0);

// Inner contour (hole) with nearly identical vertices
p5.beginContour();
p5.vertex(-10, -10, 0);
p5.vertex(-10, 10, 0);
// This vertex has x coordinate almost equal to previous (10.00000001 vs 10)
p5.vertex(10.00000001, 10, 0);
p5.vertex(10, -10, 0);
p5.endContour();

p5.endShape(p5.CLOSE);

screenshot();
});
});
});
Loading