Woff support #7449
Open
Woff support #7449
+2,330
−3,506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepagurek
reviewed
Dec 28, 2024
There was a problem hiding this comment.
Looks like the test for this still exists, were these meant to be deleted? If not, we can restore by running this then committing the results:
git checkout dev-2.0 -- "test/unit/visual/screenshots/Typography/textWeight/can control variable fonts from files"
davepagurek
reviewed
Dec 28, 2024
| @@ -17,7 +17,8 @@ | |||
| "gifenc": "^1.0.3", | |||
| "libtess": "^1.2.2", | |||
| "omggif": "^1.0.10", | |||
| "opentype.js": "^1.3.1" | |||
| "opentype.js": "^1.3.1", | |||
There was a problem hiding this comment.
oh this reminds me, we can probably npm uninstall opentype.js too if we no longer use it
davepagurek
reviewed
Dec 28, 2024
|
|
||
| if (typeof family !== 'string') { | ||
| throw Error('null font passed to textFont', font); | ||
| else if (typeof font === 'string') { |
There was a problem hiding this comment.
Good catch for this one! Do we have a test yet anywhere that checks for a raw canvas string that includes the font size? If not, it could be a good thing to add to make sure we don't accidentally break it going forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: 'can control variable fonts from files' visual test is now failing - any idea @davepagurek ?