Skip to content

Banner script update to fix the missing banner #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Banner script update to fix the missing banner #972

merged 1 commit into from
Sep 17, 2025

Conversation

Iron-56
Copy link
Contributor

@Iron-56 Iron-56 commented Sep 15, 2025 •
edited
Loading

Changes

  • Fixes the banner show functionality when script is loaded externally.
  • Uses inline script to show the banner instead of the default external one.

Why is this needed?

  • External scripts failed since execution timing differed and inline scripts worked.
  • The banner script was loaded using external script by astro. Here external script is not required as the HTML is parsed directly just before the script execution. Changing the default external script to inline fixes the bug.

How was this tested?

  • Manually tested in Firefox using npm build and preview

Fixes #967

@ksen0 ksen0 merged commit 6e4af3f into processing:main Sep 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing banner at home page
2 participants
@Iron-56 @ksen0