Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scripts to clear parsers/in and parsers/out after build:reference #731

Merged

Conversation

webermayank
Copy link
Contributor

Fixes the issue #722

The following changes had been done in this PR

  1. Added a function cleanUpDirectory in scripts/utils.ts
  2. Call that function in reference.ts which will be executed at the end of all the processes to clean the cloned p5.js and p5.sound.js repo in scripts/parsers/in and out too

after that dev server is starting faster without any errors

@davepagurek tell me if anything need changes, i would love to do so

@davepagurek
Copy link
Collaborator

Nice, this looks good! Have you tried running npm run build:reference and then npm run dev? (Doing so will change a bunch of files in the reference folder that we don't want to commit just yet, so after testing you can run npm run custom:cleanup to clean those changes out.)

@webermayank
Copy link
Contributor Author

Yes @davepagurek i tried npm run build:reference this has build the cloned repo along with some modifications in lots of files in reference/en directory files, and then npm run dev , the server started, and after that i did npm run custom:cleanup, the files that changes in reference/en reverted back hence everything worked perfectly without any errors

@davepagurek
Copy link
Collaborator

ok perfect, thanks for checking! This looks good to go then!

@davepagurek davepagurek merged commit e2b3ed0 into processing:main Mar 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants