Fix of Educational Site #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content shows up twice. Remove the Content from the site (as its already included in the BaseLayout.
davepagurek
reviewed
Sep 26, 2024
| @@ -39,5 +39,4 @@ setJumpToState({ | |||
| variant="item" | |||
| topic="tutorials" | |||
| > | |||
| <Content /> | |||
There was a problem hiding this comment.
Thanks for the fix! Since we're no longer using this, I think we can delete these lines too, which I believe are only used for creating the Content component used here:
p5.js-website/src/pages/education-resources/index.astro
Lines 10 to 13 in 6a83470
There was a problem hiding this comment.
I removed the last line. The other two are actually requried.
Removing obsolete lines according to conversation on pull request: processing#574
Two of the three lines were actually required. And cannot be removed.
Fixed the removal of code (see pull request)
calebfoss
pushed a commit
to calebfoss/p5.js-website
that referenced
this pull request
Jan 24, 2025
Removing obsolete lines according to conversation on pull request: processing#574
calebfoss
pushed a commit
to calebfoss/p5.js-website
that referenced
this pull request
Jan 27, 2025
Removing obsolete lines according to conversation on pull request: processing#574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content shows up twice. Remove the Content from the site (as its already included in the BaseLayout.
See also current version here: https://p5js.org/education-resources/