Skip to content

Pr05 Typescript Migration #20: Refine server/types & client/reducer types #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Pr05 Typescript Migration #20: Refine server/types & client/reducer types #3704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9fc95a9
client/modules/User/reducers: update to ts, no-verify
clairep94 Oct 26, 2025
fda6632
client/modules/Users/reducers: update to named export and add types, …
clairep94 Oct 26, 2025
9623321
server/types/apiKey: add token? to apiKey
clairep94 Oct 26, 2025
3533425
server/PublicUser: update apiKeys to be sanitised api keys
clairep94 Oct 26, 2025
6bcdebf
update UserState in root redux to include User
clairep94 Oct 26, 2025
2c0342d
resolve remaining type-errors from PublicUser vs User apiKey differences
clairep94 Oct 26, 2025
70880de
client/modules/User/actions: update to ts, no-verify
clairep94 Oct 26, 2025
0ddb69d
client/modules/User/actions: add types from server user request/respo…
clairep94 Oct 26, 2025
aae6687
server/types/apiKey: update to add comment about token property on la…
clairep94 Oct 26, 2025
90335b3
server/types/apiKey: update toJson method return type to IApiKey
clairep94 Oct 26, 2025
276356f
server/types/PublicUser: update with accurate PublicUser apiKeys, sho…
clairep94 Oct 26, 2025
ad4df7a
client/modules/User/reducers: update root state of state.user to add …
clairep94 Oct 26, 2025
997180a
server/types/user: remove typo for totalSize optional
clairep94 Oct 27, 2025
64db3d2
client/modules/User/reducers: update user state with correct emailVer…
clairep94 Oct 27, 2025
789447a
add GetRootState function type, and refactor modules/User/actions & p…
clairep94 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/modules/IDE/actions/preferences.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import type {
UpdatePreferencesDispatch,
SetPreferencesTabValue,
SetFontSizeValue,
GetRootState,
SetLineNumbersValue,
SetAutocloseBracketsQuotesValue,
SetAutocompleteHinterValue,
Expand All @@ -20,6 +19,7 @@ import type {
SetLanguageValue,
SetThemeValue
} from './preferences.types';
import type { GetRootState } from '../../../reducers';

function updatePreferences(
formParams: UpdatePreferencesRequestBody,
Expand Down
4 changes: 1 addition & 3 deletions client/modules/IDE/actions/preferences.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as ActionTypes from '../../../constants';
import type { PreferencesState } from '../reducers/preferences';
import type { RootState } from '../../../reducers';
import type { GetRootState } from '../../../reducers';

// Value Definitions:
export type SetPreferencesTabValue = PreferencesState['tabIndex'];
Expand Down Expand Up @@ -112,5 +112,3 @@ export type PreferencesThunk = (
dispatch: UpdatePreferencesDispatch,
getState: GetRootState
) => void;

export type GetRootState = () => RootState;
Loading
Loading