-
Notifications
You must be signed in to change notification settings - Fork 4
[FEAT] Add description in the 'blog' and 'news' pages #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
♻️ PR Preview e4453ee has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
b65fa5a
to
a8e4813
Compare
a8e4813
to
6c52840
Compare
Co-authored-by: Souchet Céline <[email protected]>
1f69dc6
to
57bb415
Compare
src/theme/pages/PageWithPosts.tsx
Outdated
<Heading | ||
as="p" | ||
color="primary" | ||
fontSize={[2, 4]} | ||
mb={[3, 5]} | ||
textAlign="center" | ||
style={centerHorizontally} | ||
> | ||
<Text width={[400, 600, 700]} key="presentation"> | ||
{description} | ||
</Text> | ||
</Heading> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I would prefer to simplify this code and the rendered objects in the DOM, like:
<Heading | |
as="p" | |
color="primary" | |
fontSize={[2, 4]} | |
mb={[3, 5]} | |
textAlign="center" | |
style={centerHorizontally} | |
> | |
<Text width={[400, 600, 700]} key="presentation"> | |
{description} | |
</Text> | |
</Heading> | |
<Text | |
as="p" | |
width={['85%', '80%', '70%']} | |
color="primary" | |
fontSize={[2, 4]} | |
mb={[3, 5]} | |
textAlign="center" | |
style={centerHorizontally} | |
> | |
{description} | |
</Text> |
It also is recommended to use 'rem' or '%' in place of 'px' in CSS.
It prevents some effect like:
px | % |
---|---|
![]() |
![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok for using percentage instead of other configuration. I took the width values from existing we had from the site, so this should be applied everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in e4453ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a future PR, I'll change all the unit for the different CSS styles 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my previous comment https://github.com/process-analytics/process-analytics.dev/pull/226/files#r757508818
covers #187