[FEAT] Create the new 'Blog' page #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♻️ PR Preview eb36b7e has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
csouchet
commented
Nov 17, 2021
| import Link from './Link'; | ||
| import { capitalize } from '../utils/string'; | ||
|
|
||
| const PageHeader = (): JSX.Element => { |
There was a problem hiding this comment.
Almost duplicated from the Header class, but we should replace the Header in the home page & have the same in all pages later.
There was a problem hiding this comment.
Ok to me, we will see later when we will decide how we manage the header on all pages
|
The margin is for the page title. Mobile formatMargin 5
Margin top 5 - bottom 4
Margin 4
Desktop formatMargin 6
Margin top 6 - bottom 5
Margin 5
|
|
|
tbouffard
reviewed
Nov 17, 2021
tbouffard
approved these changes
Nov 17, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers #187
Accessible from : http://localhost:8000/blog and https://process-analytics-process-analytics-dev-site_preview-pr-224.surge.sh/blog
All page titles are updated and follow 'PAGE_NAME - Process Analytics', except the Home page which keeps 'Process Analytics'.