Fix all Copilot review issues by capy-ai[bot] · Pull Request #6 · priyanshrv1-oss/OpenNOW1

capy-ai · 2026-04-22T18:41:18Z

Fixes all Copilot AI review comments from PR OpenCloudGaming#344

…rror recovery state sync, ARIA semantics, SavedAccount type usage Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

Copilot

Pull request overview

This PR addresses prior automated review feedback by tightening types in the main-process auth service and adjusting renderer navbar accessibility attributes for the account switcher UI.

Changes:

Update AuthService.getSavedAccounts() to return the shared SavedAccount type.
Adjust ARIA attributes/roles for the navbar account dropdown trigger and popup.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`opennow-stable/src/renderer/src/components/Navbar.tsx`	Updates ARIA attributes/roles for the account dropdown trigger and container.
`opennow-stable/src/main/gfn/auth.ts`	Uses shared `SavedAccount` typing for the saved accounts API surface.

+   367	                className="navbar-user navbar-user--clickable"
+   368	                onClick={() => setAccountDropdownOpen((previous) => !previous)}
+   369	                aria-expanded={accountDropdownOpen}
+   370	                aria-haspopup="listbox"


+   391	                <div className="navbar-account-dropdown" role="list" aria-label="Switch account">
+   392	                  <div className="navbar-account-dropdown-header">Switch Account</div>


capy-ai

Added 3 comments

PriyanshAg-1 · 2026-04-22T18:49:53Z

@copilot apply changes based on the comments in this thread

Copilot

Pull request overview

This PR follows up on PR OpenCloudGaming#344 by addressing prior Copilot review feedback across the renderer navbar and main-process auth service.

Changes:

Adjusts the Navbar account-switch dropdown ARIA attributes/roles.
Refactors AuthService.getSavedAccounts() to return the shared SavedAccount[] contract type.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File	Description
`opennow-stable/src/renderer/src/components/Navbar.tsx`	Updates accessibility attributes/roles for the account dropdown UI.
`opennow-stable/src/main/gfn/auth.ts`	Aligns saved-account typing with shared contract and tweaks session refresh/expiry result handling.

PriyanshAg-1 · 2026-04-22T18:59:21Z

+   365	              <button
+   366	                type="button"
+   367	                className="navbar-user navbar-user--clickable"
+   368	                onClick={() => setAccountDropdownOpen((previous) => !previous)}
+   369	                aria-expanded={accountDropdownOpen}
+   370	                aria-haspopup="listbox"
+   371	              >
+   372	                {user.avatarUrl ? (
+   373	                  <img src={user.avatarUrl} alt={user.displayName} className="navbar-avatar" />
+   374	                ) : (
+   375	                  <div className="navbar-avatar-fallback">
+   376	                    <User size={14} />
+   377	                  </div>
+   378	                )}
+   379	                <div className="navbar-user-info">
+   380	                  <span className="navbar-username">{user.displayName}</span>
+   381	                  {tierInfo && (
+   382	                    <span className={`navbar-tier ${tierInfo.className}`}>{tierInfo.label}</span>
+   383	                  )}
+   384	                </div>
+   385	                <ChevronDown
+   386	                  size={14}
+   387	                  className={`navbar-user-chevron${accountDropdownOpen ? " is-open" : ""}`}
+   388	                />
+   389	              </button>
+   390	              {accountDropdownOpen && (
+   391	                <div className="navbar-account-dropdown" role="list" aria-label="Switch account">
+   392	                  <div className="navbar-account-dropdown-header">Switch Account</div>


@copilot apply changes based on this feedback

Already addressed in commit 9eae745. The account dropdown now uses consistent menu semantics: aria-haspopup="menu" on the trigger, role="menu" on the container, and role="menuitem" on all four interactive buttons (account switch, remove, add account, sign out all).

PriyanshAg-1 · 2026-04-22T18:59:17Z

+  1102	    if (!tokens.clientToken && !tokens.refreshToken) {
+  1103	      if (expired) {
+  1104	        await this.logout();
+  1105	        return {
+  1106	          session: null,
+  1107	          refresh: {
+  1108	            attempted: true,
+  1109	            forced: forceRefresh,
+  1110	            outcome: "missing_refresh_token",
+  1111	            message: "Saved session expired and has no refresh mechanism. Please log in again.",
+  1112	          },
+  1113	        };


@copilot apply changes based on this feedback

Fixed in commit 9eae745. After await this.logout(), session: null is now replaced with session: this.getSession() in the !tokens.clientToken && !tokens.refreshToken expired branch. The logout() method updates all in-memory state synchronously (deletes current session, advances activeUserId to next saved account) before its async persist() call, so getSession() correctly returns the new active session after the await.

PriyanshAg-1 · 2026-04-22T18:55:11Z

@copilot apply changes based on the comments in this thread

PriyanshAg-1 · 2026-04-22T18:55:52Z

@copilot apply changes based on the comments in this thread

PriyanshAg-1 · 2026-04-22T18:58:32Z

@copilot apply changes based on the comments in this thread

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…after logout Agent-Logs-Url: https://github.com/priyanshrv1-oss/OpenNOW1/sessions/bc9cb33e-8e97-4cf8-8986-2a9a584abddc Co-authored-by: PriyanshAg-1 <204138848+PriyanshAg-1@users.noreply.github.com>

Copilot · 2026-04-22T19:05:57Z

@copilot apply changes based on the comments in this thread

Fixed in commit 9eae745. The account dropdown now uses consistent menu semantics throughout: aria-haspopup="menu" on the trigger button, role="menu" on the dropdown container, and role="menuitem" on all interactive buttons inside (account switch, remove, add account, sign out all).

@copilot apply changes based on the comments in this thread

Fixed in commit 9eae745 — see the reply to the inline comment thread for details on the ARIA menu role changes and the auth session fix.

Copilot

Pull request overview

This PR addresses prior Copilot review feedback from PR OpenCloudGaming#344 by tightening multi-account/session behavior in the main auth service and improving ARIA semantics for the renderer account switch dropdown.

Changes:

Renderer: updates the account switch dropdown to use menu semantics (aria-haspopup="menu", role="menu", role="menuitem").
Main: updates AuthService.getSavedAccounts() to return the shared SavedAccount[] type and keeps session state consistent in refresh/expiry flows.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File	Description
opennow-stable/src/renderer/src/components/Navbar.tsx	Adjusts account dropdown ARIA roles/attributes and related UI structure.
opennow-stable/src/main/gfn/auth.ts	Aligns saved-account typing with shared contract and refines session refresh/expiry handling.

PriyanshAg-1 · 2026-04-22T19:36:36Z

+   391	                <div className="navbar-account-dropdown" role="menu" aria-label="Switch account">
+   392	                  <div className="navbar-account-dropdown-header">Switch Account</div>
+   393	                  <div className="navbar-account-list">


@copilot apply changes based on this feedback

Fixed in commit ffab5bb. Added role="none" to the three non-interactive structural wrapper elements inside role="menu": the header div (.navbar-account-dropdown-header), the list wrapper (.navbar-account-list), and each account row wrapper (.navbar-account-item). The divider already had role="separator". All interactive buttons retain role="menuitem", so the ARIA owned-element contract for role="menu" is now valid.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…ne numbers in TS files Agent-Logs-Url: https://github.com/priyanshrv1-oss/OpenNOW1/sessions/f707cd73-f431-41cf-96a8-c5e0c34ab939 Co-authored-by: PriyanshAg-1 <204138848+PriyanshAg-1@users.noreply.github.com>

Copilot · 2026-04-22T19:41:19Z

@copilot apply changes based on the comments in this thread

Already addressed in commit 9eae745 (aria-haspopup="menu", role="menu" on container, role="menuitem" on buttons). The structural wrapper fix (comment 3126368408) was then applied in ffab5bb.

@copilot apply changes based on the comments in this thread

Already addressed — ARIA menu roles fixed in 9eae745, structural wrappers (role="none") and role="separator" divider fixed in ffab5bb.

@copilot apply changes based on the comments in this thread

Already addressed — ARIA menu roles fixed in 9eae745, structural wrappers (role="none") and role="separator" divider fixed in ffab5bb.

@copilot apply changes based on the comments in this thread

Already addressed — ARIA menu roles fixed in 9eae745, structural wrappers (role="none") and role="separator" divider fixed in ffab5bb.

Copilot

Pull request overview

Updates the account-switch dropdown accessibility semantics in the renderer and aligns the main-process AuthService.getSavedAccounts() return type with the shared cross-process contract in @shared/gfn.

Changes:

Adjusts the Navbar account dropdown ARIA roles (presentational wrappers, separator, menuitems).
Replaces an inline getSavedAccounts() return type with the shared SavedAccount interface.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
opennow-stable/src/renderer/src/components/Navbar.tsx	Refines ARIA roles within the account dropdown to better match menu semantics.
opennow-stable/src/main/gfn/auth.ts	Uses `SavedAccount[]` from `@shared/gfn` for `getSavedAccounts()` to keep the shared contract consistent.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR aims to address prior Copilot review feedback from PR OpenCloudGaming#344 by adjusting the navbar account dropdown’s accessibility markup and aligning the main-process getSavedAccounts() return type with the shared SavedAccount contract.

Changes:

Updated the account dropdown trigger/popup attributes in Navbar.tsx (ids/aria-controls, roles, divider semantics).
Replaced an inline structural type in AuthService.getSavedAccounts() with the shared SavedAccount interface.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.

File	Description
`opennow-stable/src/renderer/src/components/Navbar.tsx`	Tweaks ARIA relationships/roles for the account dropdown UI.
`opennow-stable/src/main/gfn/auth.ts`	Uses `SavedAccount` from `@shared/gfn` for `getSavedAccounts()` typing.

                    })}
                  </div>
-                  <div className="navbar-account-divider" />
+                  <div className="navbar-account-divider" aria-hidden="true" />


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

PriyanshAg-1 · 2026-04-22T19:58:16Z

@copilot apply changes based on the comments in this thread

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Fix all remaining Copilot review issues: auth session null returns, e…

b3909af

…rror recovery state sync, ARIA semantics, SavedAccount type usage Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

PriyanshAg-1 requested a review from Copilot April 22, 2026 18:42

Copilot started reviewing on behalf of PriyanshAg-1 April 22, 2026 18:42 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

capy-ai Bot commented Apr 22, 2026

View reviewed changes

Repository owner deleted a comment from capy-ai Bot Apr 22, 2026

PriyanshAg-1 requested a review from Copilot April 22, 2026 18:50

Copilot started reviewing on behalf of PriyanshAg-1 April 22, 2026 18:51 View session

PriyanshAg-1 mentioned this pull request Apr 22, 2026

Fix insufficient playability error and session promotion #7

Open

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Potential fix for pull request finding

df76988

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of PriyanshAg-1 April 22, 2026 18:59 View session

fix: use menu ARIA roles in account dropdown and return getSession() …

9eae745

…after logout Agent-Logs-Url: https://github.com/priyanshrv1-oss/OpenNOW1/sessions/bc9cb33e-8e97-4cf8-8986-2a9a584abddc Co-authored-by: PriyanshAg-1 <204138848+PriyanshAg-1@users.noreply.github.com>

Copilot finished work on behalf of PriyanshAg-1 April 22, 2026 19:06

Copilot AI requested a review from PriyanshAg-1 April 22, 2026 19:06

Copilot started work on behalf of PriyanshAg-1 April 22, 2026 19:06 View session

Copilot finished work on behalf of PriyanshAg-1 April 22, 2026 19:07

PriyanshAg-1 requested a review from Copilot April 22, 2026 19:14

Copilot started reviewing on behalf of PriyanshAg-1 April 22, 2026 19:14 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Potential fix for pull request finding

bfde5dc

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of PriyanshAg-1 April 22, 2026 19:36 View session

fix: add role=none to structural wrappers in menu and fix embedded li…

ffab5bb

…ne numbers in TS files Agent-Logs-Url: https://github.com/priyanshrv1-oss/OpenNOW1/sessions/f707cd73-f431-41cf-96a8-c5e0c34ab939 Co-authored-by: PriyanshAg-1 <204138848+PriyanshAg-1@users.noreply.github.com>

Copilot finished work on behalf of PriyanshAg-1 April 22, 2026 19:42

PriyanshAg-1 requested a review from Copilot April 22, 2026 19:44

Copilot started reviewing on behalf of PriyanshAg-1 April 22, 2026 19:44 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Comment thread opennow-stable/src/renderer/src/components/Navbar.tsx Outdated

Potential fix for pull request finding

a0bf7b5

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

PriyanshAg-1 requested a review from Copilot April 22, 2026 19:49

Copilot started reviewing on behalf of PriyanshAg-1 April 22, 2026 19:49 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

PriyanshAg-1 and others added 2 commits April 23, 2026 01:26

Change logoutAll to logout in auth service

42d4257

Potential fix for pull request finding

463cfe4

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

PriyanshAg-1 and others added 2 commits April 23, 2026 01:29

Potential fix for pull request finding

96c57e7

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

72a2b4f

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

PriyanshAg-1 requested a review from Copilot April 22, 2026 19:59

Copilot started reviewing on behalf of PriyanshAg-1 April 22, 2026 20:00 View session

PriyanshAg-1 approved these changes Apr 22, 2026

View reviewed changes

PriyanshAg-1 self-requested a review April 22, 2026 20:11

PriyanshAg-1 merged commit 75c26e9 into main Apr 22, 2026
4 of 9 checks passed

capy-ai Bot removed the request for review from Copilot April 22, 2026 20:24

		391 <div className="navbar-account-dropdown" role="list" aria-label="Switch account">
		392 <div className="navbar-account-dropdown-header">Switch Account</div>

Conversation

capy-ai Bot commented Apr 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

capy-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

PriyanshAg-1 commented Apr 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

PriyanshAg-1 Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

PriyanshAg-1 Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PriyanshAg-1 commented Apr 22, 2026

Uh oh!

PriyanshAg-1 commented Apr 22, 2026

Uh oh!

PriyanshAg-1 commented Apr 22, 2026

Uh oh!

Copilot AI commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

PriyanshAg-1 Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PriyanshAg-1 commented Apr 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 22, 2026 •

edited

Loading

Copilot AI commented Apr 22, 2026 •

edited

Loading