refactor!: change Go module path to github.com/privateerproj/pvtr - #313
Merged
Merged
Conversation
## What/Why The repository is now privateerproj/pvtr, so the module path moves to github.com/privateerproj/pvtr to match. `go install github.com/privateerproj/privateer@<new version>` fails after this release with "module declares its path as github.com/privateerproj/pvtr". Install with `go install github.com/privateerproj/pvtr@latest` instead. Versions before this release still install under the old path. release-drafter now resolves the `breaking` label to a minor bump while pvtr is pre-1.0. This release becomes v0.24.0 and still lists the change under Breaking Changes. ## Proof it works make build passes (go vet, go test, binary). golangci-lint reports 0 issues, and test/install_test.sh passes. ## Risk Medium. Anyone who installs pvtr with `go install` on the old path must switch paths when they move to this version. Pinned installs of older versions keep working. install.sh, Homebrew and release archives are unaffected. ## AI role Claude Opus 5.5 made the change and ran the checks. A human reviews the PR. ## Review focus The release-drafter change: `breaking` now resolves to minor until 1.0. Signed-off-by: jmeridth <jmeridth@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The module references are consistent and the release resolver correctly implements the documented pre-1.0 behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the Go module path to match the repository and adjusts pre-1.0 release versioning.
Changes:
- Migrates the module and internal import to
github.com/privateerproj/pvtr. - Maps
breakingchanges to minor releases before 1.0.
| File | Description |
|---|---|
main.go |
Updates the internal command import. |
go.mod |
Changes the declared module path. |
.github/release-drafter.yml |
Resolves breaking changes as minor releases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why
The repository is now privateerproj/pvtr, and this changes the Go module path to match. After this release, install with
go install github.com/privateerproj/pvtr@latest. The old path fails for new versions with "module declares its path as github.com/privateerproj/pvtr". Older versions still install under the old path.It also makes release-drafter resolve
breakingto a minor bump while pvtr is pre-1.0. This release becomes v0.24.0 and still gets a Breaking Changes section.Proof it works
make build, golangci-lint andtest/install_test.shpass.go install github.com/privateerproj/pvtr@99b293dbuilds a working binary, and the old path at the same commit fails with the expected "module declares its path" error.Risk
Medium. Anyone installing with
go installon the old path has to switch when they move to this version. install.sh, Homebrew and release archives are unaffected.AI role
Claude Opus 5.5 made the change and ran the checks. A human reviews the PR.
Review focus
The release-drafter change:
breakingresolves to minor until 1.0.