Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cobra presistenflags getting wired up at the correct time #71

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jmeridth
Copy link
Member

No description provided.

@jmeridth jmeridth self-assigned this Jan 15, 2025
@Copilot Copilot bot review requested due to automatic review settings January 15, 2025 23:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (1)

cmd/root.go:57

  • Ensure that the new behavior introduced by calling command.ReadConfig() is covered by tests.
command.ReadConfig()

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@github-actions github-actions bot added the fix label Jan 15, 2025
@jmeridth jmeridth requested a review from a team January 15, 2025 23:37
@eddie-knight eddie-knight merged commit 3ed9577 into main Jan 15, 2025
4 checks passed
@eddie-knight eddie-knight deleted the jm_update_sdk_and_cobra_wire_up branch January 15, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants