fix: goreleaser stuff #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jmeridth <[email protected]>
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.
eddie-knight
previously approved these changes
Jan 3, 2025
jmeridth
force-pushed
the
jm_fix_goreleaser
branch
from
56acf77 to
ceff99b
Compare
jmeridth
changed the title
- [x] rebuild .goreleaser.yml from scratch to meet new version (goreleaser init) - copy over pieces we need from old config - verified good with `goreleaser check` - [x] change goreleaser github action to fire on newly published releases, not new tags Our new release github action will create the release and do all the templating based on conventional commits pr titles and auto-labelling. Now goreleaser will see the newly published release and attach the new asset builds to the new release. Signed-off-by: jmeridth <[email protected]>
jmeridth
force-pushed
the
jm_fix_goreleaser
branch
from
ceff99b to
698289a
Compare
eddie-knight
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
goreleaser checkOur new release github action will create the release and do all the templating based on conventional commits pr titles and auto-labelling. Now goreleaser will see the newly published release and attach the new asset builds to the new release.
Was tested in https://github.com/jmeridth/test-reusable-release-with-goreleaser