-
Notifications
You must be signed in to change notification settings - Fork 128
Bump puma from 6.6.1 to 7.1.0 in /demo #3743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
siddharthkp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major upgrade, tests are failing. Going to say no to this
|
@siddharthkp do you know what we use this dep for? Wondering if it's going to hurt us in the long run to stay on an old version |
|
puma is a webserver used only in /demo: https://github.com/primer/view_components/blob/main/docs/contributors/README.md#documentation--demo-rails-app Don't think we use it for anything public facing anymore. cc @jonrohan |
|
It's used for branch deploys and if you're running lookbook locally |
|
|
@dependabot recreate |
Bumps [puma](https://github.com/puma/puma) from 6.6.1 to 7.1.0. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/main/History.md) - [Commits](puma/puma@v6.6.1...v7.1.0) --- updated-dependencies: - dependency-name: puma dependency-version: 7.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dab7ffd to
6e2e273
Compare
Bumps puma from 6.6.1 to 7.1.0.
Release notes
Sourced from puma's releases.
... (truncated)
Changelog
Sourced from puma's changelog.
... (truncated)
Commits
fb2a073v7.1.0 (#3797)4edb9e9client.rb-read_body- cleanup last lines of method (#3798)84a568aUpdate wait_for_less_busy_worker docs (#3757)e59a604Initialize only essentialLauncherstate beforeprune_bundlerrestart (#3...6844de7client.rb - Skip reading zero bytes when request body is buffered (#3795)1d3d6b7SetThread.current.puma_serverin Thread init code, not every request (#3774)9b34cdeAdding syntax highlighting in k8s docs (#3782)a2bd2f6Addprune_bundlertoConfiguration::DEFAULTS(#3779)d7a0854ci: Update hey benchmark files, minor fixes and formatting (#3796)ff08099ci: Update Update test/rackup/sleep_fibonacci.ru, add test script (#3793)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)