Skip to content

Fix: DataTable issue loading prop true hides empty message #8292 #8297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: DataTable issue loading prop true hides empty message #8292 #8297

wants to merge 3 commits into from

Conversation

@sarathkumarsasi
Copy link
Contributor

@sarathkumarsasi sarathkumarsasi commented Sep 22, 2025 •
edited by melloware
Loading

Refactor empty message handling in TableBody, DataView, and TreeTableBody components to always return the empty message instead of null when not loading.
Fix #8292

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@sarathkumarsasi
Copy link
Contributor Author

sarathkumarsasi commented Sep 22, 2025 •
edited
Loading

#8292.

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

1 similar comment
@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Sep 22, 2025
@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@sarathkumarsasi
Copy link
Contributor Author

sarathkumarsasi commented Oct 11, 2025 •
edited
Loading

#8292

@sarathkumarsasi
Copy link
Contributor Author

@melloware, I am not able to link the ticket to issue #8292. Can you help?

@melloware
Copy link
Member

@sarathkumarsasi i linked it you can ignore that error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mertsincan mertsincan Awaiting requested review from mertsincan

1 more reviewer

@prevuelta prevuelta prevuelta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mertsincan mertsincan

Labels

Status: Pending Review Issue or pull request is being reviewed by Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataTable: loading prop true hides empty message

4 participants

@sarathkumarsasi @melloware @prevuelta @mertsincan