Skip to content

Fix the truncation problem when saving to netcdf5 after merging #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 26, 2025

Conversation

mikapfl
Copy link
Member

@mikapfl mikapfl commented Mar 24, 2025

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Description in a {pr}.thing.md file in the directory changelog added - see changelog/README.md for details

Description

Fix the truncation problem when saving to netcdf5 after merging.

Closes: #325

Add a default compression algorithm level and compression level if nothing is specified.

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.17%. Comparing base (1283beb) to head (9ca89d2).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   97.15%   97.17%   +0.01%     
==========================================
  Files          49       49              
  Lines        4748     4773      +25     
==========================================
+ Hits         4613     4638      +25     
  Misses        135      135              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crdanielbusch crdanielbusch self-assigned this Mar 24, 2025
@crdanielbusch
Copy link
Collaborator

Ready for review @mikapfl

Copy link
Member Author

@mikapfl mikapfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. We need a small changelog entry, then we're ready to merge.

@mikapfl mikapfl merged commit 2c77a5d into main Mar 26, 2025
18 checks passed
@mikapfl mikapfl deleted the fix-encoding-netcdf5 branch March 26, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strings in coordinates may be truncated when saving to netcfd
2 participants