bugfix(issue #14): add in destroy method

[chrisrng]

Fixes issue #14

[ghost]

Hi @chrisrng , can we add an example to the Demo product to demonstrate how to use the .destroy?

[ghost]

Non-blocking question, @chrisrng , can we expand the .destroy accepted parameter to accept as object instead of a boolean flag? Perhaps define some good names as accepted object keys to be expressive by native object key names, and the values of the object keys would be your choice of appropriate data type, i.e.:

memoryLeak.destroy({
  isCompleteDestroy: true
});

or

memoryLeak.destroy({
  isDestroyRefrencesOnly: true
});

Think if one sets up the accepted parameter with object with meaningful named object keys to control the .destroy API, it would pave the scalability of the .destroy API, if the .destroy API ever expands.

[jimmyangel]

Any plans to merge this PR into master? Thank you.

[chrisrng]

Hey @jimmyangel ! Unfortunately I no longer work at Priceline, left almost 2 years ago :)

I think this PR is good to go tho ... 2 years ago haha

[Emuentes]

@BeniCheni @jxnblk
Is there any reason that @chrisrng's PR was never merged? Just curious ;-)

[jxnblk]

Sorry, we don't have any active maintainers for this project. It should probably be archived and clearly stated in the readme

[joshbDev]

fwiw I think @chrisrng and myself would be more than happy to be maintainers for the project

[Emuentes]

Well the flat-line is a good indicator. I hadn't thought about whether it was in active development or not ;-)

@joshbDev @chrisrng maybe it's time for a "based on" spin-off ;-)

[BeniCheni]

Think if anyone is interested in becoming maintainer(s) of omni-slider, perhaps the interested maintainer(s) can work with @ pricelinelabs to fork the omni-slider repo out of the @ pricelinelabs & transfer the authorship and maintainer roles & responsibility out of @ pricelinelabs.

Echoing @ jxnblk's previous comment, @ pricelinelabs doesn't have any active maintainer(s) to support omni-slider.