[#679] [모임 생성] 모임 생성 퍼널 종료기능 추가 #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanyugeon
added
🐥 프론트
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
⚡️ Lighthouse Average Scores Across Reports:
⚡️ Average Details Across All Reports:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 내용
모임 생성 퍼널 종료기능 추가했어요
이전으로 가기아이콘을닫기아이콘으로 수정했어요StickyFooter를 작성하고 기존의BottomActionButton을 대체했어요스크린샷
퍼널 바텀액션 버튼 적용 화면
퍼널 종료 버튼 모달 적용 화면
pr 포인트
해당 코드 위주로 리뷰해주시면 편해요!
이전 코드를 수정하다보니 부득이하게 Files Changed 카운트가 많아졌어요 😭
새로 작성한
StickyFooter.tsx를 우선적으로 보시면 될 것 같아요!Help
합성 컴포넌트 네이밍FunnelBottomActionButton라는 네이밍과Submit혹은Previous라는 합성 컴포넌트 이름까지 함께 사용하다보니컴포넌트 사용부 쪽에서 코드 가독성이 떨어지는 느낌이 있는 것 같아요 😭관련 이슈