Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#657] 네비게이션 스키마 작성 #660

Merged
merged 4 commits into from
Jul 11, 2024
Merged

[#657] 네비게이션 스키마 작성 #660

merged 4 commits into from
Jul 11, 2024

Conversation

hanyugeon
Copy link
Member

구현 내용

위 이미지는 구글에 "당근"을 검색했을때 나오는 UI예요.

"당근" 검색 결과 처럼 "다독다독"을 검색했을때 저희 서비스가 노출된다면
북카이브, 도서검색, 독서모임, 내프로필 4가지 항목이 보일 수 있도록 네비게이션 스키마를 작성했어요

스크린샷

Screen.Recording.2024-07-12.at.3.00.50.AM.mov

schema.org에서 네비게이션 스키마 마크업이
올바르게 적용됐는지 테스트하는 영상이에요

Help

각 항목에 대한 description

constants/metadata/scheme.ts에 각 항목에 대한 description을 임시로 제가 적어 두었어요.

  • 북카이브: 같은 직군인 유저들의 책장과 인기 도서를 추천받고 인사이트를 넓혀보세요
  • 도서검색: 평소에 궁금했거나 함께 이야기 나누고 싶은 도서를 검색해보세요
  • 독서모임: 읽고 싶은 책을 선정하고 모임에 참여하여 멤버들과 이야기를 나눠보세요
  • 내프로필: 내 책장을 관리하고 참여한 독서 모임들을 확인해보세요

더 자연스럽거나 어울리는 문구가 있다면 적어주셔도 좋아요 🤣

관련 이슈

@hanyugeon hanyugeon added 🐥 프론트 필수! ✨ feature New feature or request 🔥 v.1.0 New feature for releasing v.1.0 labels Jul 11, 2024
@hanyugeon hanyugeon requested a review from gxxrxn July 11, 2024 18:16
@hanyugeon hanyugeon self-assigned this Jul 11, 2024
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dadok ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 7:12pm

Copy link

github-actions bot commented Jul 11, 2024

Comment on lines 64 to 67
<script
type="application/ld+json"
dangerouslySetInnerHTML={{ __html: JSON.stringify(navigationSchema) }}
/>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment;

해당 script태그를 line54에 있는 <GoogleAnalytic />처럼 컴포넌트로 분리를 해볼까요!? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4;

해당 script태그를 line54에 있는 처럼 컴포넌트로 분리를 해볼까요!? 🤔

다른 컴포넌트들도 추상화가 되어있는 상태라 맞추면 좋을 것 같아요!!

+) 찾아보니 next에 Script 컴포넌트가 있어요!! 이걸 활용해보면 어떨까요??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gxxrxn

반영하였습니다! c081e23
Next/Script 컴포넌트도 활용했어요!

Copy link

github-actions bot commented Jul 11, 2024

⚡️ Lighthouse Average Scores Across Reports:

Category Score
🔴 performance 69
🟢 accessibility 91
🟢 best practices 98
🟢 seo 100
🟢 pwa 100

⚡️ Average Details Across All Reports:

Category Score
🟢 first contentful paint 0.8s
🔴 largest contentful paint 12.8s
🟠 interactive 7.3s
🟢 total blocking time 240.0ms
🟢 cumulative layout shift 0.0

gxxrxn
gxxrxn previously approved these changes Jul 11, 2024
Copy link
Member

@gxxrxn gxxrxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와.. 너무 좋아요..🥺 SEO 끝판왕!! 코멘트 하나만 확인해주세요!! 수고하셨습니다! 👍🏻

Comment on lines 64 to 67
<script
type="application/ld+json"
dangerouslySetInnerHTML={{ __html: JSON.stringify(navigationSchema) }}
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4;

해당 script태그를 line54에 있는 처럼 컴포넌트로 분리를 해볼까요!? 🤔

다른 컴포넌트들도 추상화가 되어있는 상태라 맞추면 좋을 것 같아요!!

+) 찾아보니 next에 Script 컴포넌트가 있어요!! 이걸 활용해보면 어떨까요??

Copy link
Member

@gxxrxn gxxrxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@hanyugeon hanyugeon merged commit ecc1840 into main Jul 11, 2024
4 checks passed
@hanyugeon hanyugeon deleted the feat/#657 branch July 11, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request 🐥 프론트 필수! 🔥 v.1.0 New feature for releasing v.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

네비게이션 스키마 작성
2 participants