Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#646] /scripts 파일을 esm으로 변경 #647

Merged
merged 3 commits into from
Jun 24, 2024
Merged

[#646] /scripts 파일을 esm으로 변경 #647

merged 3 commits into from
Jun 24, 2024

Conversation

gxxrxn
Copy link
Member

@gxxrxn gxxrxn commented Jun 24, 2024

@gxxrxn gxxrxn added 🐥 프론트 필수! 📦 chore Not important changes 🔥 v.1.0 New feature for releasing v.1.0 labels Jun 24, 2024
@gxxrxn gxxrxn requested a review from hanyugeon June 24, 2024 08:07
@gxxrxn gxxrxn self-assigned this Jun 24, 2024
Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dadok ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 9:25am

Copy link

github-actions bot commented Jun 24, 2024

Copy link

github-actions bot commented Jun 24, 2024

⚡️ Lighthouse Average Scores Across Reports:

Category Score
🔴 performance 66
🟢 accessibility 91
🟢 best practices 98
🟢 seo 100
🟢 pwa 100

⚡️ Average Details Across All Reports:

Category Score
🟢 first contentful paint 0.9s
🔴 largest contentful paint 12.4s
🔴 interactive 8.3s
🟢 total blocking time 228.9ms
🟢 cumulative layout shift 0.0

@gxxrxn gxxrxn changed the title [#646] /scripts에서 require문 사용 가능하도록 eslint 설정 추가 [#646] /scripts 파일을 esm으로 변경 Jun 24, 2024
Copy link
Member

@hanyugeon hanyugeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CommonJS와 ESM에 대해 조금씩 알아가고있는것 같아 좋네요 😁

@gxxrxn gxxrxn merged commit df269d3 into main Jun 24, 2024
4 checks passed
@gxxrxn gxxrxn deleted the chore/#646 branch June 24, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐥 프론트 필수! 📦 chore Not important changes 🔥 v.1.0 New feature for releasing v.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/scripts 파일을 esm으로 변경
2 participants