Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#640] 로그인하지 않은 사용자의 진입점을 로그인 페이지로 수정 #643

Merged
merged 3 commits into from
Jun 23, 2024
Merged

[#640] 로그인하지 않은 사용자의 진입점을 로그인 페이지로 수정 #643

merged 3 commits into from
Jun 23, 2024

Conversation

gxxrxn
Copy link
Member

@gxxrxn gxxrxn commented Jun 23, 2024

구현 내용

  • 루트 path '/' 로 접근한 경우, middleware를 통해 쿠키의 refreshToken 유무에 따라 다른 경로로 리다이렉팅되도록 수정했어요.
    • refreshToken이 존재하는 경우, /bookarchive 로 리다이렉팅
    • refreshToken이 없는 경우, /login 로 리다이렉팅

스크린샷

관련 이슈

@gxxrxn gxxrxn added 🐥 프론트 필수! ✨ feature New feature or request 🔥 v.1.0 New feature for releasing v.1.0 labels Jun 23, 2024
@gxxrxn gxxrxn requested a review from hanyugeon June 23, 2024 11:27
@gxxrxn gxxrxn self-assigned this Jun 23, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dadok ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 11:54am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 23, 2024 •
edited
Loading

🚀 Storybook: https://64aba10cd478ad51307a8997-xigvowyeez.chromatic.com/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 23, 2024 •
edited
Loading

⚡️ Lighthouse Average Scores Across Reports:

Category Score
🔴 performance 67
🟢 accessibility 91
🟢 best practices 98
🟢 seo 100
🟢 pwa 100

⚡️ Average Details Across All Reports:

Category Score
🟢 first contentful paint 0.8s
🔴 largest contentful paint 12.2s
🟠 interactive 6.9s
🟢 total blocking time 291.3ms
🟢 cumulative layout shift 0.0

hanyugeon
hanyugeon approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@hanyugeon hanyugeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gxxrxn gxxrxn merged commit 7ec54b3 into main Jun 23, 2024
4 checks passed
@gxxrxn gxxrxn mentioned this pull request Jun 23, 2024
Merged
@gxxrxn gxxrxn deleted the feat/#640 branch June 23, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyugeon hanyugeon hanyugeon approved these changes

Assignees

@gxxrxn gxxrxn

Labels
✨ feature New feature or request 🐥 프론트 필수! 🔥 v.1.0 New feature for releasing v.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

로그인하지 않은 사용자의 진입점을 로그인 페이지로 수정
2 participants
@gxxrxn @hanyugeon