Feature/bad word deactivate(wr9 34) #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
leeys9423
reviewed
Feb 19, 2025
| @RequestBody @Valid UpdateBadWordStatusRequest request) { | ||
|
|
||
| badWordService.updateBadWordStatus(badWordId, request); | ||
| return ResponseEntity.ok(BaseResponse.of(null, "๊ธ์น์ด ์ํ ๋ณ๊ฒฝ ์๋ฃ")); |
There was a problem hiding this comment.
๊ฒ์ด๋จ์ด, ๊ธ์น์ด ๋จ์ด๋ฅผ ํต์ผ์ํค๋๊ฒ ์ข์ง ์์๊น์?!
- null ๋ฐํ๋ ์ข์ง๋ง, ์ด๋ป๊ฒ update ๋์๋์ง ๋ฐํํด์ฃผ๋๊ฒ๋ ์ข์๋ณด์ ๋๋ค. but ํด๋น ๊ธฐ๋ฅ์ ํ๋ฉด์ด ์์ต๋๋ค.
| @@ -26,4 +26,10 @@ public class BadWord extends BaseEntity { | |||
| @Column(nullable = false) | |||
| private Boolean isUsed; | |||
There was a problem hiding this comment.
Wrapper ํ ๋ณด๋ค ๊ธฐ๋ณธํ ์ฐ๋๊ฒ ์ข์๋ณด์ ๋๋ค.
์? why? ๊ธฐ๋ณธํ์ ์ฌ์ฉ์ ์ด์ฐจํผ ๊ธฐ๋ณธ๊ฐ์ด false์ด๋ค. wrapper ์ฐ๋ฉด ํน์ ๋ชจ๋ฅผ Null๊ฐ์ ์กฐ์ฌํด์ผํ๋ค. ๊ทธ๋ฆฌ๊ณ ์์ฃผ ๊นจ์๊ฐ์ ๋ฉ๋ชจ๋ฆฌ ์ธก๋ฉด์์๋ ๊ธฐ๋ณธํ์ด ๋์ก์๋จน์ผ๋๊น ๊ธฐ๋ณธํ์ ์ฐ๋๊ฒ ์ข์๋ณด์ ๋๋ค.
leeys9423
reviewed
Feb 19, 2025
| @AllArgsConstructor | ||
| public class UpdateBadWordStatusRequest { | ||
| @NotNull(message = "์ํ๊ฐ์ ํ์์ ๋๋ค.") | ||
| private Boolean isUsed; |
There was a problem hiding this comment.
๋ฐ์ ๋ฐ๊พธ๋ฉด ์ด๋ถ๋ถ๋ ๋ฐ๊ฟ์ฃผ์๋๊ฒ ์ข์ ๊ฒ ๊ฐ์์..
ํต์ผ์ฑ ์งํค๊ธฐ
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
๐ PR ์ค๋ช
๊ธ์น์ด ์ํ ๋ณ๊ฒฝ(ํ์ฑํ/๋นํ์ฑํ) ๊ธฐ๋ฅ ์ถ๊ฐ
๐ ์ฃผ์ ๋ณ๊ฒฝ์ฌํญ
๐ธ ์คํฌ๋ฆฐ์ท (์ ํ์ฌํญ)
๐งช ํ ์คํธ
โ ์ฒดํฌ๋ฆฌ์คํธ
๐ค ๊ด๋ จ ์ด์