Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/read share board(wr9 25) #30

Merged
merged 15 commits into from
Feb 19, 2025
Merged

Feature/read share board(wr9 25) #30

merged 15 commits into from
Feb 19, 2025

Conversation

HeoJeongHyeon
Copy link
Collaborator

@HeoJeongHyeon HeoJeongHyeon commented Feb 19, 2025 •
edited
Loading

Pull Request Template

πŸ“ PR μ„€λͺ…

  • GET /api/share-posts
  • SharePost κ΄€λ ¨ Entity,enum,dto μΆ”κ°€
  • SharePostController, SharePostService μΆ”κ°€
  • ErrorCode νŽ˜μ΄μ§• μ—λŸ¬μ²˜λ¦¬ μΆ”κ°€

πŸ§ͺ ν…ŒμŠ€νŠΈ

  • λ‹¨μœ„ ν…ŒμŠ€νŠΈ μΆ”κ°€/μˆ˜μ •
  • ν…ŒμŠ€νŠΈ 컀버리지 확인
  • μ†Œλ‚˜ν΄λΌμš°λ“œ ν’ˆμ§ˆ 게이트 톡과

βœ… 체크리슀트

  • μ½”λ“œ μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν–ˆλ‚˜μš”?
  • λΆˆν•„μš”ν•œ μ½”λ“œλ‚˜ 주석이 μ—†λ‚˜μš”?
  • 브랜치 넀이밍 μ»¨λ²€μ…˜μ„ λ”°λžλ‚˜μš”?
  • κ΄€λ ¨ λ¬Έμ„œλ₯Ό μ—…λ°μ΄νŠΈν–ˆλ‚˜μš”?

🀝 κ΄€λ ¨ 이슈

JeongHYeon-Heo added 10 commits February 19, 2025 14:26
feat 곡유 νŽ˜μ΄μ§€ μ—λŸ¬μ½”λ“œ
2f71747 
ErrorCode.INVALID_PAGE_REQUEST
feat Entity, Dto
a966c7a 
SharePost
ShareProposal
shareProposalLetter
SharePostLike μ—”ν‹°ν‹° μΆ”κ°€
SharePostResponse DTO μΆ”κ°€
feat Entity
1ae8437 
shareProposalLetter
feat enum
5abbc99 
enum파일 μΆ”κ°€
feat entity
46c8182 
ShareProposal
feat 곡유 νŽΈμ§€ κ²Œμ‹œνŒ 쑰회
ab7f923 
νŽ˜μ΄μ§€λ‘œ λͺ©λ‘ 쑰회
test 곡유 νŽΈμ§€ κ²Œμ‹œνŒ 쑰회
fd68283 
Controller , Service
refactor ErrorCode,build.gradle
57c9ed2 
ErrorCode
- ,, λ“€μ–΄κ°„κ±° μ‚­μ œ
build.gradle
- **/repository/** μ œμ™ΈνŒ¨ν„΄ μΆ”κ°€
Merge branch 'dev' into feature/read-share-board(WR9-25)
e69d653 
# Conflicts:
#	src/main/java/io/crops/warmletter/global/error/common/ErrorCode.java
refactor SharePostResponse
bb24ec0 
SharePostResponse refactor
@HeoJeongHyeon HeoJeongHyeon linked an issue Feb 19, 2025 that may be closed by this pull request
[WR9-25] 곡유 κ²Œμ‹œνŒ 쑰회 #24
Closed
leeys9423
leeys9423 reviewed Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@leeys9423 leeys9423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€

μ „μ²΄μ μœΌλ‘œ BaseEntity와 BaseTimeEntityκ°€ 잘λͺ» ν™œμš© 되고 μžˆλŠ”κ²ƒ κ°™μ•„μš”.

ν•΄λ‹Ή ν…Œμ΄λΈ”μ—μ„œ μƒμ„±μž, μƒμ„±μ‹œκ°„, μˆ˜μ •μž, μˆ˜μ •μ‹œκ°„μ„ ν•„μš”λ‘œ ν•˜λŠ” 엔티티이면 BaseEntityλ₯Ό 상속
ν•΄λ‹Ή ν…Œμ΄λΈ”μ—μ„œ μƒμ„±μ‹œκ°„, μˆ˜μ •μ‹œκ°„μ„ ν•„μš”λ‘œ ν•˜λŠ” 엔티티이면 BaseTimeEntityλ₯Ό 상속

ν…Œμ΄λΈ”μͺ½μ—μ„œλŠ” ν•΄λ‹Ή ν•„λ“œλ₯Ό μ„ μ–Έν•˜μ§€ μ•ŠμŒ. (이게 좔상 클래슀λ₯Ό μ‚¬μš©ν•˜λŠ” μ΄μœ μž…λ‹ˆλ‹€)

src/main/java/io/crops/warmletter/domain/share/entity/SharePost.java Outdated
Comment on lines 36 to 38
private String createdBy;

private String updatedBy;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당뢀뢄은 이미 BaseEntity에 μ •μ˜λ˜μ–΄ 있기 λ•Œλ¬Έμ— μ§€μš°μ…”μ•Ό ν•  것 κ°™μ•„μš”!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„΅ μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€. !

src/main/java/io/crops/warmletter/domain/share/entity/SharePost.java Outdated
Comment on lines 31 to 34
@Column(nullable = false)
private String title;

private String content;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이뢀뢄 λΉ„μ¦ˆλ‹ˆμŠ€ 둜직으둜 생각해볼 λ•Œ,

ν™”λ©΄ μƒμ—μ„œ content κ΄€λ ¨λœ 것 만 적게 λ˜μ–΄μžˆμ—ˆμž–μ•„μš”.(ν”Όκ·Έλ§ˆ μ°Έκ³ )

일단 ν”„λ‘ νŠΈλΆ„λ“€μ—κ²Œ μš”μ²­ μͺ½μ—μ„œ title을 μ‚¬μš©ν•˜μ‹€κ±΄μ§€μ— λŒ€ν•΄μ„œ 여쭀보고 erd μˆ˜μ •ν•˜λŠ” λ°©ν–₯으둜 가야될 것 κ°™μŠ΅λ‹ˆλ‹€.

λ§Œμ•½ title을 μ•ˆμ“°κ³  ν˜„μž¬ ν™”λ©΄ κ·ΈλŒ€λ‘œ κ°„λ‹€κ³  ν–ˆμ„ λ•Œ, 곡유 νŽΈμ§€ κ²Œμ‹œνŒμ— 제λͺ©μ„ μ–΄λ–»κ²Œ 섀정해쀄거냐 λΌλŠ” 회의 μ£Όμ œλ„ λ‚˜μ™€μ•Ό ν•  것 κ°™κ³ μš”

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„΅ 이 λΆ€λΆ„ λ”°λ‘œ μ–˜κΈ° λ‚˜λˆ„μ–΄ λ³΄κ² μŠ΅λ‹ˆλ‹€.

src/main/java/io/crops/warmletter/domain/share/entity/SharePost.java Outdated
@Column(nullable = false)
private Long shareProposalId;

private boolean isActive = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boolean νƒ€μž…μ˜ κΈ°λ³Έ 값은 falseλΌμ„œ λͺ…μ‹œμ μœΌλ‘œ μ΄ˆκΈ°ν™” ν•΄ 쀄 ν•„μš”λŠ” μ—†λ‹€κ³  μƒκ°ν•©λ‹ˆλ‹€~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ§žμŠ΅λ‹ˆλ‹€ !

src/main/java/io/crops/warmletter/domain/share/entity/SharePost.java Outdated
Comment on lines 40 to 45
@Builder
public SharePost(Long shareProposalId, String title, String content) {
this.shareProposalId = shareProposalId;
this.title = title;
this.content = content;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

처음 곡유 νŽΈμ§€ κ²Œμ‹œνŒμ— 글이 등둝될 λ•Œ isActive(ν™œμ„±ν™” μ—¬λΆ€)값이 true둜 섀정이 λ˜μ–΄μ•Ό κ²Œμ‹œνŒμ— λ…ΈμΆœμ΄ 될텐데 ν•΄λ‹Ή ν•„λ“œλ„ μƒμ„±μžμ— λ„£μ–΄μ•Ό 될 κ±° κ°™μ•„μš”

그리고 좔후에 μ‹ κ³  μ²˜λ¦¬μ— λ”°λΌμ„œ κ²Œμ‹œκΈ€μ΄ λΉ„ν™œμ„±ν™” λ˜λŠ” κ²½μš°λ„ μžˆμž–μ•„μš” κ·Έλ•Œλ₯Ό μœ„ν•΄μ„œ inactive(), active()λΌλŠ” ν•¨μˆ˜λ₯Ό 미리 λ§Œλ“€μ–΄ 놔도 쒋지 μ•Šμ„κΉŒ? λΌλŠ” 생각이 μžˆμŠ΅λ‹ˆλ‹€

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ²Œμ‹œλ¬Ό 상세 쑰회 APIμ—μ„œ ν•΄λ‹Ή ν•¨μˆ˜λ₯Ό μΆ”κ°€ν•˜λ €κ³  ν–ˆμŠ΅λ‹ˆλ‹€ ! μš°μ„ , 미리 λ„£μ–΄λ‘λŠ” 걸둜 ν•˜κ² μŠ΅λ‹ˆλ‹€ ! μΆ”κ°€λ‘œ, Repositoryμ—μ„œ κ³΅μœ κ²Œμ‹œνŒ λͺ©λ‘μ„ μ‘°νšŒν•  λ•Œ
이미 true인 κ²Œμ‹œκΈ€λ§Œ ν•΄λ‹Ή DB에 μ‘΄μž¬ν•˜κ² μ§€λ§Œ,
isActiveκ°€ true인 λͺ©λ‘λ“€λ§Œ μ‘°νšŒν•˜λ„λ‘ λ°”κΎΈλŠ”κ²Œ μ’‹μ„κΉŒμš” ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„€ Userμͺ½μ—μ„œ μ‚¬μš©ν•˜λŠ” κΈ°λŠ₯이라고 μƒκ°ν•˜λ©΄ isActive 값이 true인 κ²ƒλ§Œ μ‘°νšŒν•΄μ˜€λŠ”κ²Œ λ§žλ‹€κ³  μƒκ°ν•©λ‹ˆλ‹€.

μΆ”ν›„ κ΄€λ¦¬μž νŽ˜μ΄μ§€μ—μ„œλŠ” λ”°λ‘œ APIλ₯Ό λ§Œλ“€μ–΄μ„œ 쿼리슀트링으둜 컨트둀 ν•  수 μžˆλ„λ‘ λ§Œλ“œλŠ”κ²Œ 쒋을 것 κ°™μ•„μš”

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„΅ κ΄€λ ¨ν•˜μ—¬ μˆ˜μ •ν•΄μ„œ PR λ„£μ—ˆμŠ΅λ‹ˆλ‹€ κ°μ‚¬ν•©λ‹ˆλ‹€ !

JeongHYeon-Heo added 5 commits February 19, 2025 17:03
refactor SharePostResponse
e5b267b 
- SharePostResponse
isActive ν•„λ“œ μΆ”κ°€
refactor SharePostResponse
3ed9eab 
- SharePostResponse
isActive ν•„λ“œ μΆ”κ°€
feat μ‹€μ œ true에 ν•œν•˜μ—¬ 값을 κ°€μ Έμ˜€λŠ” λ©”μ„œλ“œμΆ”κ°€
472dc6d 
μ‹€μ œ true값에 λŒ€ν•œ κ²Œμ‹œκΈ€λ§Œ 쑰회
test ν…ŒμŠ€νŠΈ 검증 μΆ”κ°€
2d59950 
- ν™œμ„±ν™”λœ κ²Œμ‹œκΈ€ λͺ©λ‘ νŽ˜μ΄μ§• 쑰회
- 음수 νŽ˜μ΄μ§€ μš”μ²­μ‹œ μ˜ˆμ™Έ λ°œμƒ
- λ‘λ²ˆμ§Έ νŽ˜μ΄μ§€ 쑰회
fix λ³€μˆ˜λͺ…λ³€κ²½μœΌλ‘œ 였λ₯˜
3792e81 
넀이밍 μ •μ •
@HeoJeongHyeon HeoJeongHyeon merged commit 2b194f3 into dev Feb 19, 2025
1 check failed
@HeoJeongHyeon HeoJeongHyeon deleted the feature/read-share-board(WR9-25) branch February 19, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeys9423 leeys9423 leeys9423 left review comments

Assignees

@HeoJeongHyeon HeoJeongHyeon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WR9-25] 곡유 κ²Œμ‹œνŒ 쑰회
2 participants
@HeoJeongHyeon @leeys9423