Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/oauth-setting(wr9-24) #27

Merged
merged 13 commits into from
Feb 19, 2025
Merged

Feature/oauth-setting(wr9-24) #27

merged 13 commits into from
Feb 19, 2025

Conversation

leeys9423
Copy link
Collaborator

@leeys9423 leeys9423 commented Feb 19, 2025

Pull Request Template

๐Ÿ“ PR ์„ค๋ช…

  • OAuth2.0 ๊ด€๋ จ ๊ธฐ๋ณธ ํด๋ž˜์Šค ํŒŒ์ผ ๊ตฌํ˜„๊ณผ ์„ค์ • ์ ์šฉ (env ํŒŒ์ผ ์ตœ์‹ ํ™” ํ•˜์…”์•ผ ํ•ฉ๋‹ˆ๋‹ค)

๐Ÿ” ์ฃผ์š” ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • OAuth ๊ด€๋ จ ๊ณตํ†ต ์—๋Ÿฌ์ถ”๊ฐ€
  • Member, SocialAccount ๊ด€๋ จ ์—”ํ‹ฐํ‹ฐ ์ƒ์„ฑ
  • application.yml ํŒŒ์ผ ์ˆ˜์ • ( OAuth ์ถ”๊ฐ€ ์„ค์ • + api key๊ฐ’ ์ถ”๊ฐ€ )
  • OAuth ์ถ”์ƒ ํด๋ž˜์Šค ์ƒ์„ฑ ํ›„ ์ œ๊ณตํ•˜๋Š” ์†Œ์…œ ๊ตฌ์ฒด ํด๋ž˜์Šค ๊ตฌํ˜„

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท (์„ ํƒ์‚ฌํ•ญ)

  • UI ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์žˆ๋‹ค๋ฉด ์Šคํฌ๋ฆฐ์ƒท์„ ์ฒจ๋ถ€ํ•ด์ฃผ์„ธ์š”.

๐Ÿงช ํ…Œ์ŠคํŠธ

  • ๋‹จ์œ„ ํ…Œ์ŠคํŠธ ์ถ”๊ฐ€/์ˆ˜์ •
  • ํ…Œ์ŠคํŠธ ์ปค๋ฒ„๋ฆฌ์ง€ ํ™•์ธ
  • ์†Œ๋‚˜ํด๋ผ์šฐ๋“œ ํ’ˆ์งˆ ๊ฒŒ์ดํŠธ ํ†ต๊ณผ

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ฝ”๋“œ ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ–ˆ๋‚˜์š”?
  • ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ๋‚˜ ์ฃผ์„์ด ์—†๋‚˜์š”?
  • ๋ธŒ๋žœ์น˜ ๋„ค์ด๋ฐ ์ปจ๋ฒค์…˜์„ ๋”ฐ๋ž๋‚˜์š”?
  • ๊ด€๋ จ ๋ฌธ์„œ๋ฅผ ์—…๋ฐ์ดํŠธํ–ˆ๋‚˜์š”?

๐Ÿค ๊ด€๋ จ ์ด์Šˆ

@leeys9423 leeys9423 added โš™ Setting ๊ฐœ๋ฐœ ํ™˜๊ฒฝ ์„ธํŒ… โœจ Feature ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ labels Feb 19, 2025
@leeys9423 leeys9423 self-assigned this Feb 19, 2025
@leeys9423 leeys9423 linked an issue Feb 19, 2025 that may be closed by this pull request
4 tasks
@leeys9423 leeys9423 added the โœ… Test test ๊ด€๋ จ(storybook, jest...) label Feb 19, 2025
Copy link

sonarqubecloud bot commented Feb 19, 2025


private String password;

@Column(nullable = false)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

column(nullable = false) ๋Œ€์‹  NotNull์„ ์‚ฌ์šฉํ•˜๋Š” ๊ฑฐ์— ๋Œ€ํ•ด์„  ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋‚˜์š”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NotNull์€ validation์— ๊ด€๋ จ๋œ ์–ด๋…ธํ…Œ์ด์…˜์ด๋ผ๊ณ  ์•Œ๊ณ ์žˆ์Šต๋‹ˆ๋‹ค!

ํ•ด๋‹น ์„ค์ •์€ ์—”ํ‹ฐํ‹ฐ ์ž–์•„์—ฌ~ ๊ทธ๋ž˜์„œ ์ปฌ๋Ÿผ์— ๋Œ€ํ•œ ์ •์˜๋ฅผ ๋‚ด๋ ค์ฃผ๊ณ  ์žˆ๋Š”๊ฑฐ์—์š”!
์ด๋ ‡๊ฒŒ ์„ค์ •ํ•ด์•ผ๋งŒ Table์ด ์ƒ์„ฑ๋  ๋•Œ Null ๋ฏธํ—ˆ์šฉ์œผ๋กœ ์ ์šฉ๋˜๋Š” ๊ฑธ๋กœ ์•Œ๊ณ ์žˆ์Šต๋‹ˆ๋‹ค

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„ ๊ทธ๋ ‡๊ฒŒ ์ƒ๊ด€์€ ์—†๋Š” ๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค
https://hereishyun.tistory.com/166
์ด๋Ÿฐ ์˜๊ฒฌ์ด ์žˆ์–ด ์—ฌ์ญค๋ดค์Šต๋‹ˆ๋‹น

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Member๊ฐ€ ์ƒ์„ฑ์ด ์•ˆ๋  ๊ฒฝ์šฐ๊ฐ€ ์žˆ์„๊นŒ์š”? (ex ๋น„๋ฐ€๋ฒˆํ˜ธ์— null์ด ๋“ค์–ด๊ฐˆ ๊ฒฝ์šฐ)
๋งŒ์•ฝ ์žˆ์œผ๋ฉด ์ƒ์„ฑ์ด ์‹คํŒจํ•ด์„œ ์ƒ๊ธฐ๋Š” ๊ฒฝ์šฐ๋„ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋กœ ์žˆ์œผ๋ฉด ์ข‹์„ ๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ผ๋‹จ ๋น„์ฆˆ๋‹ˆ์Šค ๋กœ์ง์ ์œผ๋กœ ์ƒ๊ฐํ•ด๋ด์•ผ ํ•  ๋ถ€๋ถ„์ด ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”!

ํ˜„์žฌ ์šฐ๋ฆฌ ์„œ๋น„์Šค๋Š” ์†Œ์…œ๋กœ๊ทธ์ธ๋งŒ ์ œ๊ณตํ•˜๊ณ  ์žˆ์ฃ !

๋”ฐ๋ผ์„œ password๋ผ๋Š” ํ•„๋“œ๋Š” ์‚ฌ์‹ค์ƒ ์‚ฌ์šฉ๋˜๊ณ  ์žˆ์งˆ ์•Š์Šต๋‹ˆ๋‹ค!

ํ•˜์ง€๋งŒ password๋ผ๋Š” ํ•„๋“œ๋ฅผ ๋”ฐ๋กœ ๋นผ๋†“์€ ์ด์œ ๋Š” ๊ด€๋ฆฌ์ž๋Š” ๊ทธ๋Ÿผ ์–ด๋–ป๊ฒŒ ๋กœ๊ทธ์ธํ•ด์•ผํ•˜์ง€? ๊ด€๋ฆฌ์ž๋Š” ์†Œ์…œ๋กœ๊ทธ์ธ์„ ์‚ฌ์šฉํ•˜์ง€ ์•Š์„๊นŒ? ๋ผ๋Š” ์ƒ๊ฐ์— ํ•„๋“œ๋ฅผ ์ƒ์„ฑํ•ด ๋†“์€ ๊ฑฐ์˜€์–ด์š”. ๊ธˆ์ผ ํšŒ์˜๋กœ ์ผ๋‹จ ๊ด€๋ฆฌ์ž ์ชฝ์€ ๋”ฐ๋กœ ์ƒ์„ฑํ•˜์ง€ ์•Š๋Š” ๋ฐฉํ–ฅ์œผ๋กœ ์–˜๊ธฐ๊ฐ€ ๋์œผ๋ฏ€๋กœ ๊ทผ๋ณธ์ ์ธ password ํ•„๋“œ๋Š” ์‚ญ์ œ๊ฐ€ ๋  ์˜ˆ์ •์ž…๋‹ˆ๋‹ค!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•Œ๊ฒ ์Šต๋‹ˆ๋‹ค~!

@leeys9423 leeys9423 merged commit ba66ff2 into dev Feb 19, 2025
3 checks passed
@leeys9423 leeys9423 deleted the feature/oauth-setting(WR9-24) branch February 19, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โœจ Feature ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ โš™ Setting ๊ฐœ๋ฐœ ํ™˜๊ฒฝ ์„ธํŒ… โœ… Test test ๊ด€๋ จ(storybook, jest...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WR9-24] OAuth2 ๊ธฐ๋ณธ ์„ค์ • ๊ตฌํ˜„
2 participants