[Refactor] Chat 메시지 기능 리팩토링 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al-project/WEB1_2_Child-Learn_BE into feature/chat/SCRUM-90 # Conflicts: # build.gradle
…al-project/WEB1_2_Child-Learn_BE into feature/chat/SCRUM-138 # Conflicts: # build.gradle # src/main/java/com/prgrms/ijuju/domain/member/service/MemberService.java # src/main/java/com/prgrms/ijuju/global/exception/CustomException.java # src/main/java/com/prgrms/ijuju/global/exception/GlobalExceptionHandler.java
…al-project/WEB1_2_Child-Learn_BE into feature/chat/SCRUM-138 # Conflicts: # src/main/java/com/prgrms/ijuju/domain/chat/entity/Chat.java # src/main/java/com/prgrms/ijuju/domain/chat/exception/ChatException.java # src/main/java/com/prgrms/ijuju/domain/chat/service/ChatService.java # src/main/java/com/prgrms/ijuju/domain/friend/entity/FriendRequest.java # src/main/java/com/prgrms/ijuju/domain/friend/exception/FriendException.java # src/main/java/com/prgrms/ijuju/domain/friend/service/FriendService.java # src/main/java/com/prgrms/ijuju/domain/stock/mid/service/MidStockTradeService.java # src/main/java/com/prgrms/ijuju/domain/wallet/entity/Wallet.java # src/main/java/com/prgrms/ijuju/domain/wallet/exception/WalletException.java # src/main/java/com/prgrms/ijuju/domain/wallet/service/TransactionService.java # src/main/java/com/prgrms/ijuju/domain/wallet/service/WalletService.java # src/main/java/com/prgrms/ijuju/global/exception/CustomException.java
1mjay
reviewed
Dec 7, 2024
| @Override | ||
| @NonNull | ||
| public MongoClient mongoClient() { | ||
| ConnectionString connectionString = new ConnectionString("mongodb://localhost:27017/ijuju"); |
1mjay
reviewed
Dec 7, 2024
Comment on lines
+7
to
+12
| public class ChatTaskException extends RuntimeException { | ||
|
|
||
| private final String code; | ||
| private final String message; | ||
| private final int statusCode; | ||
| private final HttpStatus httpStatus; |
There was a problem hiding this comment.
글로벌 에러처리 대신 사용하신 이유가 있을까요? httpStatus와 statusCode를 같이 쓰신 이유도 궁금합니다!
There was a problem hiding this comment.
글로벌 에러 처리는 이미 완료했습니다.이 파일은 제거되어야 하는데 제거 대상에서 빠진 것 같아요. 다음 PR 때 삭제하겠습니다.
1mjay
reviewed
Dec 7, 2024
Comment on lines
+10
to
+14
| public class ApiResponse<T> { | ||
| private String code; | ||
| private String message; | ||
| private T data; | ||
| private int statusCode; |
There was a problem hiding this comment.
엇 ApiResponse 만드셨네요 ~! 다음에 다같이 적용해보면 좋을 것 같습니다 👍
There was a problem hiding this comment.
글로벌 에러 처리로 파일 제거 대상 파일이었는데 누락되었습니다. 다음 PR 때 삭제하겠습니다.
1mjay
reviewed
Dec 7, 2024
Comment on lines
+19
to
+20
| main: | ||
| allow-bean-definition-overriding: true |
There was a problem hiding this comment.
배포 환경에 포함되면 안됩니다. yml파일에서도 제거 할 예정입니다.
chanspar
reviewed
Dec 7, 2024
There was a problem hiding this comment.
data:
mongodb:
uri: mongodb://localhost:27017/ijuju
redis:
host: localhost
port: 6379
수정이 필요하네요
|
리뷰 감사합니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #84
#️⃣ 연관된 이슈 번호
related #84 : [Refactor] Chat 메시지 기능 리팩토링
✅ PR 유형
📝 작업 내용
🔍 테스트 결과
채팅방 생성
채팅방 조회
채팅방 목록 조회
채팅방 삭제
메시지 전송
MongoDB 적용
🎈 변경 사항 체크리스트
✨ 피드백 반영사항
💬 리뷰 요구사항