[4기 한승원] URL Shortener 과제 PR입니다. #48
Open
SW-H wants to merge 20 commits intoprgrms-be-devcourse:seungwonfrom
Open
[4기 한승원] URL Shortener 과제 PR입니다. #48SW-H wants to merge 20 commits intoprgrms-be-devcourse:seungwonfrom
SW-H wants to merge 20 commits intoprgrms-be-devcourse:seungwonfrom
Conversation
hyee0715
approved these changes
Oct 11, 2023
hyee0715
left a comment
hyee0715
left a comment
There was a problem hiding this comment.
승원님 코드 잘 봤습니다! 깔끔하게 코드 잘 짜신 것 같고, 리뷰 드리면서 제가 많이 배워가는 것 같습니다 ㅎㅎ 바쁜 일정에 과제 하시느라 고생 많으셨어요~ 👍
Comment on lines
+23
to
+24
|
|
||
| private String originalUrl; |
There was a problem hiding this comment.
엔티티에도 originalUrl에 nullable=false 처리를 해주시는 건 어떨까요?!
Suggested change
| private String originalUrl; | |
| @Column(nullable = false) | |
| private String originalUrl; |
Comment on lines
+40
to
+42
| UrlValidator validator = new UrlValidator(); | ||
|
|
||
| return validator.isValid(url); |
There was a problem hiding this comment.
UrlValidator로 유효성 검사 하는 방법도 있군요 ! 배워갑니다 👍
Comment on lines
+17
to
+19
| private final Bucket bucket = Bucket.builder() | ||
| .addLimit(Bandwidth.simple(CAPACITY, Duration.ofMinutes(DURATION))) | ||
| .build(); |
hyee0715
reviewed
Oct 11, 2023
Comment on lines
+12
to
+14
| Optional<Url> findByShortUrlKey(@Param("shortUrlKey") String shortUrlKey); | ||
|
|
||
| int countByOriginalUrl(@Param("originalUrl") String originalUrl); |
There was a problem hiding this comment.
Suggested change
| Optional<Url> findByShortUrlKey(@Param("shortUrlKey") String shortUrlKey); | |
| int countByOriginalUrl(@Param("originalUrl") String originalUrl); | |
| Optional<Url> findByShortUrlKey(String shortUrlKey); | |
| int countByOriginalUrl(String originalUrl); |
@param을 제거해도 문제 없을 것 같습니다 ㅎㅎ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
사용자가 입력한 url에 대해 더 짧은 형태인 단축 url을 제공하는 서비스 입니다
👩💻 요구 사항과 구현 내용
https://shortenworld.kro.krScreen.Recording.2023-10-09.at.10.54.46.PM.mov