Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pullrequest: 컨트롤러 테스트 코드 초안 병합 요청 #35

Merged
merged 3 commits into from
Sep 30, 2024
Merged

pullrequest: 컨트롤러 테스트 코드 초안 병합 요청 #35

merged 3 commits into from
Sep 30, 2024

Conversation

juwon-code
Copy link
Collaborator

#️⃣연관된 이슈

Related: #21

☑️ PR 유형

  • 테스트 추가, 테스트 리팩토링
  • 빌드 부분 혹은 패키지 매니저 수정

📝 작업 내용

각 도메인 컨트롤러에 해당하는 테스트 코드를 짜보았습니다.

✅ 피드백 반영사항

어디까지나 초안이고, 아직 덜 구현하신 파트는 제외하고 작성했습니다.

💬 리뷰 요구사항

#34 번 이슈 확인 해주시고, Approve 부탁드립니다!!!

juwon-code and others added 3 commits September 29, 2024 14:08
@juwon-code
merge: 컨트롤러 테스트 브랜치 최신화
e31f19f 
`main` -> `dev/test/controller`
컨트롤러 테스트 코드를 작성하기 전, 브랜치를 최신화합니다.

Related to: #21
@juwon-code
chore: 시큐리티 테스트 의존성 추가
bd6f32b 
테스트에 필요한 Spring Security Test 의존성을 추가합니다.

Related to: #21
@juwon-code
test: 컨트롤러 테스트 코드 추가
a733c59 
각 도메인의 컨트롤러에 해당하는 테스트 코드 초안을 추가합니다.

Related to: #21
@juwon-code juwon-code self-assigned this Sep 29, 2024
@juwon-code juwon-code linked an issue Sep 29, 2024 that may be closed by this pull request
test: 컨트롤러 테스트 코드 작성 #21
Open
6 tasks
YooJHyun
YooJHyun approved these changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@YooJHyun YooJHyun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 주말간 고생많으셨습니다! 추가 변동 사항 생기면 말씀드리겠습니다!
Merge PR은 다른 팀원들도 확인할 수 있도록 일단 보류해두겠습니다!

@juwon-code juwon-code requested a review from YooJHyun September 29, 2024 12:39
@juwon-code
Copy link
Collaborator Author

juwon-code commented Sep 29, 2024 •
edited
Loading

넵! 감사합니다. 저녁 약속 끝나고 #34 번 이슈 작성 완료했습니다. 내일 회의에서 같이 얘기하시면 좋을 것 같습니다!^^

ghtndl
ghtndl approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@ghtndl ghtndl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트코드 작성하느라 고생하셨습니다

deveunhwa
deveunhwa approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@deveunhwa deveunhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 수고하셨습니다!

@juwon-code juwon-code merged commit 5d891f3 into main Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghtndl ghtndl ghtndl approved these changes

@deveunhwa deveunhwa deveunhwa approved these changes

@jungyoeal jungyoeal Awaiting requested review from jungyoeal

@Preta3418 Preta3418 Awaiting requested review from Preta3418

@YooJHyun YooJHyun Awaiting requested review from YooJHyun

Assignees

@juwon-code juwon-code

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: 컨트롤러 테스트 코드 작성
4 participants
@juwon-code @ghtndl @YooJHyun @deveunhwa