Improve raise printing (#66)

* Add broken tests for #65

* Add long raise test

* Fix typo

* Improve raise printing

* Add another test for raise

* Use groupConcat and indentConcat

src/printer/index.js

@@ -1074,7 +1074,15 @@ function genericPrint(path, options, print) {
       // on python2 exc is called type
       const type = n.type ? "type" : "exc";
 
-      return group(concat(["raise", line, path.call(print, type)]));
+      return concat([
+        "raise",
+        groupConcat([
+          ifBreak(" (", " "),
+          indentConcat([softline, path.call(print, type)]),
+          softline,
+          ifBreak(")")
+        ])
+      ]);
     }
 
     case "Return": {

tests/python_raise/__snapshots__/jsfmt.spec.js.snap

@@ -0,0 +1,95 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`raise.py 1`] = `
+raise
+raise ValueError
+raise ValueError("error")
+
+raise NotImplementedError('example.')
+
+raise forms.ValidationError(
+    self.error_messages['invalid_login'],
+    code='invalid_login',
+    params={
+        'username': self.username_field.verbose_name
+    }
+)
+
+raise SomeErrorWithAReallyReallyVeryVeryExtremelyExtensivelyLongNameSoItBreaks()
+
+raise NotImplementedError(
+    'The SimpleListFilter.lookups() method must be overridden to '
+    'return a list of tuples (value, verbose value).'
+)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+raise
+raise ValueError
+raise ValueError("error")
+
+raise NotImplementedError("example.")
+
+raise (
+    forms.ValidationError(self.error_messages[
+        "invalid_login"
+    ], code="invalid_login", params={
+        "username": self.username_field.verbose_name
+    })
+)
+
+raise (
+    SomeErrorWithAReallyReallyVeryVeryExtremelyExtensivelyLongNameSoItBreaks()
+)
+
+raise (
+    NotImplementedError('The SimpleListFilter.lookups() method must be overridden to '
+    'return a list of tuples (value, verbose value).')
+)
+
+`;
+
+exports[`raise.py 2`] = `
+raise
+raise ValueError
+raise ValueError("error")
+
+raise NotImplementedError('example.')
+
+raise forms.ValidationError(
+    self.error_messages['invalid_login'],
+    code='invalid_login',
+    params={
+        'username': self.username_field.verbose_name
+    }
+)
+
+raise SomeErrorWithAReallyReallyVeryVeryExtremelyExtensivelyLongNameSoItBreaks()
+
+raise NotImplementedError(
+    'The SimpleListFilter.lookups() method must be overridden to '
+    'return a list of tuples (value, verbose value).'
+)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+raise
+raise ValueError
+raise ValueError("error")
+
+raise NotImplementedError("example.")
+
+raise (
+    forms.ValidationError(self.error_messages[
+        "invalid_login"
+    ], code="invalid_login", params={
+        "username": self.username_field.verbose_name
+    })
+)
+
+raise (
+    SomeErrorWithAReallyReallyVeryVeryExtremelyExtensivelyLongNameSoItBreaks()
+)
+
+raise (
+    NotImplementedError('The SimpleListFilter.lookups() method must be overridden to '
+    'return a list of tuples (value, verbose value).')
+)
+
+`;

tests/python_raise/jsfmt.spec.js

@@ -0,0 +1,2 @@
+run_spec(__dirname, ["python"], { pythonVersion: "2" });
+run_spec(__dirname, ["python"], { pythonVersion: "3" });

tests/python_raise/raise.py

@@ -0,0 +1,20 @@
+raise
+raise ValueError
+raise ValueError("error")
+
+raise NotImplementedError('example.')
+
+raise forms.ValidationError(
+    self.error_messages['invalid_login'],
+    code='invalid_login',
+    params={
+        'username': self.username_field.verbose_name
+    }
+)
+
+raise SomeErrorWithAReallyReallyVeryVeryExtremelyExtensivelyLongNameSoItBreaks()
+
+raise NotImplementedError(
+    'The SimpleListFilter.lookups() method must be overridden to '
+    'return a list of tuples (value, verbose value).'
+)