-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental operator position #1097
Open
Janther
wants to merge
13
commits into
main
Choose a base branch
from
experimentalOperatorPosition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1069c36
to
c7d8568
Compare
4c7910c
to
e74e728
Compare
2873d58
to
d834976
Compare
… has precedence over equality
…are the binary operations that that should force grouping and indentation
d834976
to
99e0d88
Compare
…equality` when it's a child of `IfStatement`, `ForStatement`, or `WhileStatement` so there's no need for separate behaviours
…ed to be exported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier v3.5.0 added a new experimental option.
Experimental options follow this policy.
These options are designed to test if the users adopt the new formatting over the old one.
So far we have been follow closely prettier's decisions regarding formatting and apply when it makes sense in a Solidity context.
This PR contains 2 changes.
Tweaking binary operation's indenting and grouping to align better with prettier's
**
*
,/
,%
+
,-
<<
,>>
|
,&
,^
<
,>
,<=
,>=
==
,!=
&&
,||
Many of these cases were already taken care of by adding parentheses in unclear cases or when everything would fit in a single line.
Since all of these behaviours follow the same rule there was a big work in standardising the printers in such a way that we can view what are the levels bellow at each level.
there is a new parentheses case added.
Tis case was added to the tests that compile and compare the byte code.
adding support for experimentalOperatorPosition