Finish documenting the Battle Castle Apps (Overlay 107)#968
Merged
lhearachel merged 3 commits intopret:mainfrom Feb 23, 2026
Merged
Finish documenting the Battle Castle Apps (Overlay 107)#968lhearachel merged 3 commits intopret:mainfrom
lhearachel merged 3 commits intopret:mainfrom
Conversation
lhearachel
reviewed
Feb 23, 2026
Collaborator
lhearachel
left a comment
lhearachel
left a comment
There was a problem hiding this comment.
Thanks for splitting this up to make it easier to review.
| app->frontier = SaveData_GetBattleFrontier(app->saveData); | ||
|
|
||
| for (int v0 = 0; v0 < 3; v0++) { | ||
| app->unk_437[v0] = 1; | ||
| for (int i = 0; i < 3; i++) { |
Collaborator
There was a problem hiding this comment.
polish: Set a constant here that can be applied to the struct-definition as well, so the ranks are always updated in case a modder changes them.
| if ((Pokemon_GetValue(v7, MON_DATA_HP, NULL) == Pokemon_GetValue(v7, MON_DATA_MAX_HP, NULL)) && (ov107_02245210(v7) == 0)) { | ||
| param0->printerID = PrintMessageAndCopyToVRAM(param0, BattleCastleSelfApp_Text_NoBenefit, FONT_MESSAGE); | ||
| param0->subState = 7; | ||
| if ((Pokemon_GetValue(mon, MON_DATA_HP, NULL) == Pokemon_GetValue(mon, MON_DATA_MAX_HP, NULL)) && (!IsMonMissingPP(mon))) { |
Collaborator
There was a problem hiding this comment.
polish: Remove unnecessary parens.
| param0->printerID = PrintMessageAndCopyToVRAM(param0, BattleCastleSelfApp_Text_RentalRankTooLow, FONT_MESSAGE); | ||
| param0->subState = 14; | ||
| return 0; | ||
| if (rank == 1) { |
Collaborator
There was a problem hiding this comment.
thought: Do we not have constants for these ranks?
Contributor
Author
There was a problem hiding this comment.
I don't think constants would do much. The rank is just a number that increments from 1 to 3. And I don't think they have any special names in-game beside the number.
lhearachel
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final continuation of #956.
Looks like git isn't recognizing the renaming of some of the files in the full PR view, but if you look at just the first commit of this PR you can see what was all changed in those files without seeing it as a delete+new file.