Skip to content

Document StartMenu_ExitPartyMenu with addressed feedback#945

Merged
lhearachel merged 5 commits intopret:mainfrom
Viperio19:exit-party-menu
Feb 16, 2026
Merged

Document StartMenu_ExitPartyMenu with addressed feedback#945
lhearachel merged 5 commits intopret:mainfrom
Viperio19:exit-party-menu

Conversation

@Viperio19
Copy link
Contributor

@Viperio19 Viperio19 commented Feb 11, 2026 •
edited
Loading

This PR contains all changes from the abandoned PR #846 and addresses the feedback on the original PR.

Original description:

First PR here. Sorry it got rather large

When player selects an action in the party menu that causes them to exit the menu the StartMenu_ExitPartyMenu callback function is called.
StartMenu_ExitPartyMenu relies on partyMenu->menuSelectionResult to act upon.

  • documented StartMenu callbacks
  • added PARTY_MENU_EXIT_CODE enum
  • documented PartyMenu selection actions in unk_02083370.c

unrelated:

  • documented sub_0202D79C -> SaveData_GetRibbons

SevenSpiders and others added 4 commits December 2, 2025 23:24
@SevenSpiders
Document StartMenu_ExitPartyMenu and PartyMenu actions
12e8b9c 
Rename PARTY_MENU_RESULTS -> PARTY_MENU_EXIT_CODE

Finish up enums

StartMenu Actions

sub_0202D79C -> SaveData_GetRibbons

Documenting Startmenu

sub_0203B674 -> StartMenu_Run
sub_0203B78C -> StartMenu_OpenPartyMenu
sub_0203B7C0-> StartMenu_ExitPartyMenu
sub_0203BC5C -> StartMenu_ExitBag

PartyMenuApplication *param0 -> application
@SevenSpiders
syntax fixes
0aa5664
@SevenSpiders
Clang format fixes
c00e534
@Viperio19
Merge branch 'main' of https://github.com/SevenSpiders/pokeplatinum i…
5d8651d 
…nto exit-party-menu
@lhearachel lhearachel self-assigned this Feb 15, 2026
lhearachel
lhearachel reviewed Feb 15, 2026
View reviewed changes
Copy link
Collaborator

@lhearachel lhearachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this one up. Some more notes below.

@lhearachel lhearachel mentioned this pull request Feb 15, 2026
Closed
@lhearachel lhearachel merged commit dec5868 into pret:main Feb 16, 2026
2 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 16, 2026
@lhearachel
Document StartMenu_ExitPartyMenu with addressed feedback (#945)
8bb672a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhearachel lhearachel lhearachel approved these changes

Assignees

@lhearachel lhearachel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Viperio19 @lhearachel @SevenSpiders