Skip to content

Document StartMenu_ExitPartyMenu with addressed feedback #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Viperio19 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Document StartMenu_ExitPartyMenu with addressed feedback #945

Viperio19 wants to merge 5 commits into from

Conversation

@Viperio19
Copy link
Contributor

@Viperio19 Viperio19 commented Feb 11, 2026 •
edited
Loading

This PR contains all changes from the abandoned PR #846 and addresses the feedback on the original PR.

Original description:

First PR here. Sorry it got rather large

When player selects an action in the party menu that causes them to exit the menu the StartMenu_ExitPartyMenu callback function is called.
StartMenu_ExitPartyMenu relies on partyMenu->menuSelectionResult to act upon.

  • documented StartMenu callbacks
  • added PARTY_MENU_EXIT_CODE enum
  • documented PartyMenu selection actions in unk_02083370.c

unrelated:

  • documented sub_0202D79C -> SaveData_GetRibbons

SevenSpiders and others added 5 commits December 2, 2025 23:24
@SevenSpiders
Document StartMenu_ExitPartyMenu and PartyMenu actions
12e8b9c 
Rename PARTY_MENU_RESULTS -> PARTY_MENU_EXIT_CODE

Finish up enums

StartMenu Actions

sub_0202D79C -> SaveData_GetRibbons

Documenting Startmenu

sub_0203B674 -> StartMenu_Run
sub_0203B78C -> StartMenu_OpenPartyMenu
sub_0203B7C0-> StartMenu_ExitPartyMenu
sub_0203BC5C -> StartMenu_ExitBag

PartyMenuApplication *param0 -> application
@SevenSpiders
syntax fixes
0aa5664
@SevenSpiders
Clang format fixes
c00e534
@Viperio19
Merge branch 'main' of https://github.com/SevenSpiders/pokeplatinum i…
5d8651d 
…nto exit-party-menu
@Viperio19
address pret#846 feedback
02e3d7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Viperio19 @SevenSpiders