Conversation
There was a problem hiding this comment.
question: Does it make sense to somehow generate this file from generated/map_prop_models.txt?
There was a problem hiding this comment.
This is an excellent suggestion and I'm currently trying to come up with a reasonably clean and Meson-ic way to accomplish this.
There was a problem hiding this comment.
LGTM, although I'm no Meson connoisseur :)
fff6278 to
4e27428
Compare
|
Feedback addressed - force push 1 moves |
|
Per discord discussion I'm going to rework this to use NAIX constants for prop models instead of |
4e27428 to
bdd135c
Compare
|
Sorry for the extremely noisy force push. Changes include:
|
Please see the original PR for more details - all of the information there still applies
The only difference in the changes in this PR and the original are:
nitroromallows us to do so.Re-opening this PR as it's been blocked by other tooling changes for a while but ultimately the concerns we had were not impactful enough to keep it blocked further (and any time new prop models get documented, it adds work to this PR).
The main issue previously was that the python conversion scripts were not as performant as a
datagentool. The intent is that the scripts in this PR will be rewritten once #852 is complete anddataprocis ready to use.There's a lot in this PR and I put together the history with intention - I'd prefer if these changes weren't squashed.