Dump Several Map-Related NARCs #939
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuruyia
reviewed
Feb 9, 2026
Contributor
There was a problem hiding this comment.
question: Does it make sense to somehow generate this file from generated/map_prop_models.txt?
Collaborator
Author
There was a problem hiding this comment.
This is an excellent suggestion and I'm currently trying to come up with a reasonably clean and Meson-ic way to accomplish this.
ravepossum
force-pushed
the
prop_bins
branch
from
4b2ee0f to
fff6278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the original PR for more details - all of the information there still applies
The only difference in the changes in this PR and the original are:
nitroromallows us to do so.Re-opening this PR as it's been blocked by other tooling changes for a while but ultimately the concerns we had were not impactful enough to keep it blocked further (and any time new prop models get documented, it adds work to this PR).
The main issue previously was that the python conversion scripts were not as performant as a
datagentool. The intent is that the scripts in this PR will be rewritten once #852 is complete anddataprocis ready to use.There's a lot in this PR and I put together the history with intention - I'd prefer if these changes weren't squashed.