Open
Conversation
lhearachel
reviewed
Feb 16, 2026
src/battle/battle_display.c
Outdated
| healthbar->damage = message->hpCalcTemp; | ||
| healthbar->level = message->level; | ||
|
|
||
| if (message->hpCalcTemp == 0x7fff) { |
Collaborator
There was a problem hiding this comment.
note: This should be a special value reserved for use by Self-Destruct / Explosion. Maybe worth annotating as much.
Contributor
Author
There was a problem hiding this comment.
Logically it makes sense to me that it should be that, but I can't find 0x7fff getting set as the value anywhere (although I might just be missing it in a sea of other 0x7fff's), so I'd prefer to just keep it like this for now (unless you have found where it gets set to that value).
Contributor
Author
There was a problem hiding this comment.
Just so it also gets mentioned here and not only on discord: 0x7fff was used as a decimal value in a subscript, so I added a constant HP_CALC_INSTANT_ZERO for it in constants/battle/battle_display.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR names almost all struct members of
Healthbarand partially documentshealthbar.c. The remaining undocumented parts ofhealthbar.care mostly graphics related stuff that I'm leaving for someone else.