Decompile overlay 18 (Pokedex app) part 1#430
Conversation
i don't have a problem
PikalaxALT
changed the title
|
Marking phase 1 ready for review. More to come. |
adrienntindall
left a comment
adrienntindall
left a comment
There was a problem hiding this comment.
Most of this is nitpicks but there's a few documentation stuff I'd like addressed before merging, notably I want to start using pokedex instead of zukan because this code base will be used by a primarily english speaking audience.
files/application/zukanlist/zkn_data/zukan_hw_data/.knarcignore-template
Show resolved
Hide resolved
include/dex_mon_measures.h
Outdated
| s16 *playerYPos; | ||
| s16 *monYPos; | ||
| s16 *playerScale; | ||
| s16 *monScale; | ||
| } PokedexData; // size=0x18 | ||
|
|
||
| struct PokedexData *PokedexData_Create(enum HeapID heapID); | ||
| void PokedexData_Delete(struct PokedexData *zkn); |
There was a problem hiding this comment.
Vestigial: zkn -> pokedexData
| PokedexAppData_UnkSub0868_State06 *r4 = &pokedexApp->unk_0868.state_06; | ||
|
|
||
| switch (r4->unk_A) { | ||
| case 0: { |
There was a problem hiding this comment.
Are the brackets necessary?
There was a problem hiding this comment.
yes, the c standard forbids declaring the following two variables inside a switch case without this bracket
| return POKEDEXAPP_MAINSEQ_14; | ||
| } | ||
| break; | ||
| case 13: { |
There was a problem hiding this comment.
Are the brackets necessary?
| static void ov18_021EE26C(PokedexAppData *pokedexApp); | ||
| static void ov18_021EE314(PokedexAppData *pokedexApp); | ||
|
|
||
| static int (*const sMainSeqFuncs[POKEDEXAPP_MAINSEQ_MAX])(PokedexAppData *pokedexApp) = { |
There was a problem hiding this comment.
While I feel that most functions in this array can be given names and documented properly, I have not used the pokedex nearly enough to know half of what's going on at a glance, so I will differ to your judgement on whether there's enough information to document these
There was a problem hiding this comment.
will do a naming pass once the overlay is finished
| return POKEDEXAPP_MAINSEQ_26; | ||
| } | ||
|
|
||
| static int PokedexApp_MainSeq_52(PokedexAppData *pokedexApp) { |
There was a problem hiding this comment.
Is this the dex search screen wait for input function?
There was a problem hiding this comment.
not sure yet, will figure it out later
| int ov18_021E5904(int a0); | ||
| int ov18_021E5908(void); | ||
|
|
||
| NarcId ov18_021E5900(void) { |
There was a problem hiding this comment.
will do a naming pass once the overlay is finished
|
Blame the ugly style changes to elfcoder and ds_protect on the clang-format pre-commit hook. |
2 participants
No description provided.