Open
Conversation
With assistance from @assamow figuring out the __attribute__ requirement.
Easy in comparison
adrienntindall
requested changes
Nov 26, 2025
Collaborator
adrienntindall
left a comment
adrienntindall
left a comment
There was a problem hiding this comment.
Mostly fine, just a few nitpicks
Assume that each comment is applied everywhere throughout the file and not just that one instance
| } | ||
|
|
||
| void ov12_02265F34(UnkBattleSystemSub17C *arg0) { | ||
| SpriteSystem *spriteSystem; // r5 |
Collaborator
There was a problem hiding this comment.
Can remove the decomp comment
|
|
||
| void ov12_02265F34(UnkBattleSystemSub17C *arg0) { | ||
| SpriteSystem *spriteSystem; // r5 | ||
| ManagedSprite *managed; |
Collaborator
There was a problem hiding this comment.
managed -> managedSprite for repo consistency
| } | ||
| } | ||
|
|
||
| void ov12_02265FD4(UnkBattleSystemSub17C *arg0, BattleSystem *bsys, s32 unk8, s32 unk9) { |
Collaborator
There was a problem hiding this comment.
bsys -> battleSystem
I believe the actual struct element is already being changed in #390 but I really need to suck it up and fix all the merge errors for that one
| } | ||
|
|
||
| void ov12_02265F7C(UnkBattleSystemSub17C *arg0) { | ||
| SpriteManager *manager = BattleSystem_GetGfxHandler(arg0->bsys); |
Collaborator
There was a problem hiding this comment.
manager -> spriteManager
| void ov12_02265F7C(UnkBattleSystemSub17C *arg0); | ||
|
|
||
| static const u16 ov12_0226E0A0[] = { | ||
| 0x88, |
|
This pull request has had no activity for 60 days and will be marked stale. If there is no further activity, it will be closed in 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully decompiled this file. All functions and data match. The file seems self contained enough to leave separate, rather than joining with the neighboring C files, though a more careful analysis of
UnkBattleSystemSub17C-related functions might change that evaluation.I didn't spend any time trying to make meaningful names for the functions. There's too many unknowns still, and I'm not sure how to find the sprite referenced by the given resource id's to identify what's being animated.