Skip to content

fix(native): Fix inserting decimal type values precision and scale #26737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkhaliqi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(native): Fix inserting decimal type values precision and scale #26737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion presto-native-execution/presto_cpp/main/types/PrestoToVeloxQueryPlan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include "presto_cpp/main/operators/ShuffleRead.h"
#include "presto_cpp/main/operators/ShuffleWrite.h"
#include "presto_cpp/main/types/TypeParser.h"
#include "velox/connectors/hive/HiveDataSink.h"
#include "velox/exec/TraceUtil.h"

using namespace facebook::velox;
Expand Down Expand Up @@ -75,6 +76,19 @@ RowTypePtr toRowType(
return ROW(std::move(names), std::move(types));
}

RowTypePtr toRowType(
const std::vector<protocol::VariableReferenceExpression>& variables,
const std::vector<TypePtr>& types) {
VELOX_CHECK_EQ(types.size(), variables.size());
std::vector<std::string> names;
names.reserve(variables.size());
for (const auto& variable : variables) {
names.emplace_back(variable.name);
}

return ROW(std::move(names), std::move(types));
}

std::shared_ptr<connector::ColumnHandle> toColumnHandle(
const protocol::ColumnHandle* column,
const TypeParser& typeParser) {
Expand Down Expand Up @@ -1526,9 +1540,18 @@ VeloxQueryPlanConverterBase::toVeloxQueryPlan(
sourceVeloxPlan,
tableWriteInfo,
taskId);

std::vector<TypePtr> tableTypes;
auto inputColumns =
std::dynamic_pointer_cast<const connector::hive::HiveInsertTableHandle>(
insertTableHandle->connectorInsertTableHandle())
->inputColumns();
for (const auto& inputColumn : inputColumns) {
tableTypes.emplace_back(inputColumn->dataType());
}
return std::make_shared<core::TableWriteNode>(
node->id,
toRowType(node->columns, typeParser_),
toRowType(node->columns, tableTypes),
node->columnNames,
columnStatsSpec,
std::move(insertTableHandle),
Expand Down
Loading