feat: Make table info JSON length configurable #26731
+152
−27
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.operator; | ||
|
|
||
| import com.facebook.airlift.configuration.Config; | ||
| import com.facebook.airlift.configuration.ConfigDescription; | ||
| import jakarta.validation.constraints.NotNull; | ||
|
|
||
| public class TableFinishConfig | ||
|
Contributor
Author
There was a problem hiding this comment. I couldn't find a better config file to put this config in, so I made my own. I'm open to suggestions on where else to put this!
Contributor
There was a problem hiding this comment. I will say, either FeaturesConfig, or make the name of this config general to incorporate similar needs in other operators? |
||
| { | ||
| private int tableFinishInfoJsonLengthLimit = 10_000_000; | ||
|
|
||
| @NotNull | ||
| public int getTableFinishInfoJsonLengthLimit() | ||
| { | ||
| return tableFinishInfoJsonLengthLimit; | ||
| } | ||
|
|
||
| @Config("table-finish-info-json-length-limit") | ||
| @ConfigDescription("Maximum number of characters in connector output metadata JSON in table finish info") | ||
| public TableFinishConfig setTableFinishInfoJsonLengthLimit(int tableFinishInfoJsonLengthLimit) | ||
| { | ||
| this.tableFinishInfoJsonLengthLimit = tableFinishInfoJsonLengthLimit; | ||
| return this; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.operator; | ||
|
|
||
| import com.google.common.collect.ImmutableMap; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import static com.facebook.airlift.configuration.testing.ConfigAssertions.assertFullMapping; | ||
| import static com.facebook.airlift.configuration.testing.ConfigAssertions.assertRecordedDefaults; | ||
| import static com.facebook.airlift.configuration.testing.ConfigAssertions.recordDefaults; | ||
|
|
||
| public class TestTableFinishConfig | ||
| { | ||
| @Test | ||
| public void testDefaults() | ||
| { | ||
| assertRecordedDefaults(recordDefaults(TableFinishConfig.class) | ||
| .setTableFinishInfoJsonLengthLimit(10_000_000)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testExplicitPropertyMappings() | ||
| { | ||
| Map<String, String> properties = new ImmutableMap.Builder<String, String>() | ||
| .put("table-finish-info-json-length-limit", "5000000") | ||
| .build(); | ||
|
|
||
| TableFinishConfig expected = new TableFinishConfig() | ||
| .setTableFinishInfoJsonLengthLimit(5_000_000); | ||
|
|
||
| assertFullMapping(properties, expected); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider using
dataSizeProperty, like QUERY_MAX_WRITTEN_INTERMEDIATE_BYTES ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I debated doing this! I think integer is actually better:
Strictly speaking, we pass this down
NFO_CODEC.toJsonWithLengthLimit(metadataInfo, jsonLengthLimit);.toJsonWithLengthLimitchecks the number of characters, not the number of bytes. That is, integer is technically "more correct"I want to support disabling the feature when passing a non-positive value.
DataSizerequires you specify units (e.g.0MB,0GB), which is awkward if you just want to disable the feature.